[GitHub] [hudi] danny0405 commented on a diff in pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096501910


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
       TaskContextSupplier taskContextSupplier,
       Option<BaseKeyGenerator> keyGeneratorOpt) {
     if (table.requireSortedRecords()) {
-      if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
-        return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig, instantTime, table, keyToNewRecords, partitionPath, fileId,
-            dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);

Review Comment:
   Let's keep the method name as `create` as is and just rollback the cdc supplemental log generation for compaction, and address in the release note that MOR table CDC is not supported for release 0.13.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org