You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/16 11:37:34 UTC
[GitHub] [dubbo-go] cityiron opened a new pull request #941: [Ftr] lint codes fix.
cityiron opened a new pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #933
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941#issuecomment-751365966
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=desc) (6379559) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.00%`.
> The diff coverage is `45.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
- Coverage 59.92% 59.92% -0.01%
===========================================
Files 260 261 +1
Lines 12840 12906 +66
===========================================
+ Hits 7695 7734 +39
- Misses 4186 4222 +36
+ Partials 959 950 -9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `80.36% <0.00%> (+1.45%)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+0.87%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-0.23%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <ø> (ø)` | |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <ø> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=footer). Last update [e2954fe...3dc72d2](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941#issuecomment-751365966
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=desc) (3dc72d2) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.07%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
- Coverage 59.92% 59.85% -0.08%
===========================================
Files 260 261 +1
Lines 12840 12909 +69
===========================================
+ Hits 7695 7727 +32
- Misses 4186 4229 +43
+ Partials 959 953 -6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `78.91% <0.00%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+0.87%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-0.23%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <ø> (ø)` | |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <ø> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=footer). Last update [e2954fe...3dc72d2](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941#issuecomment-751365966
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=desc) (3dc72d2) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.11%`.
> The diff coverage is `42.85%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
- Coverage 59.92% 59.81% -0.12%
===========================================
Files 260 261 +1
Lines 12840 12909 +69
===========================================
+ Hits 7695 7722 +27
- Misses 4186 4233 +47
+ Partials 959 954 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `78.91% <0.00%> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+0.87%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-0.23%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <ø> (ø)` | |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <ø> (ø)` | |
| ... and [28 more](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=footer). Last update [e2954fe...3dc72d2](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941#issuecomment-751365966
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=desc) (6379559) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.00%`.
> The diff coverage is `45.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
- Coverage 59.92% 59.92% -0.01%
===========================================
Files 260 261 +1
Lines 12840 12906 +66
===========================================
+ Hits 7695 7734 +39
- Misses 4186 4222 +36
+ Partials 959 950 -9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `80.36% <0.00%> (+1.45%)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+0.87%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-0.23%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <ø> (ø)` | |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <ø> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=footer). Last update [e2954fe...6379559](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #941: [Ftr] lint codes fix.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #941:
URL: https://github.com/apache/dubbo-go/pull/941#issuecomment-751365966
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=h1) Report
> Merging [#941](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=desc) (6379559) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/e2954fe8d0b38213628e7d15a0fe71de7b6ca6b4?el=desc) (e2954fe) will **decrease** coverage by `0.00%`.
> The diff coverage is `45.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #941 +/- ##
===========================================
- Coverage 59.92% 59.92% -0.01%
===========================================
Files 260 261 +1
Lines 12840 12906 +66
===========================================
+ Hits 7695 7734 +39
- Misses 4186 4222 +36
+ Partials 959 950 -9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/condition/router.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY29uZGl0aW9uL3JvdXRlci5nbw==) | `80.36% <0.00%> (+1.45%)` | :arrow_up: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (+0.87%)` | :arrow_up: |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.33% <0.00%> (-0.23%)` | :arrow_down: |
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `88.11% <ø> (ø)` | |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `52.47% <ø> (ø)` | |
| [...lter\_impl/tps/tps\_limit\_sliding\_window\_strategy.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRfc2xpZGluZ193aW5kb3dfc3RyYXRlZ3kuZ28=) | `100.00% <ø> (ø)` | |
| [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `39.72% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `49.33% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `48.17% <0.00%> (-2.19%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <ø> (ø)` | |
| ... and [30 more](https://codecov.io/gh/apache/dubbo-go/pull/941/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=footer). Last update [e2954fe...6379559](https://codecov.io/gh/apache/dubbo-go/pull/941?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org