You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/02/15 19:16:28 UTC

[GitHub] larroy commented on a change in pull request #9677: Refactor operators and add MKLDNN

larroy commented on a change in pull request #9677: Refactor operators and add MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/9677#discussion_r168579350
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -610,7 +611,18 @@ endif()
 
 if(USE_OPENCV)
   add_executable(im2rec "tools/im2rec.cc")
-  target_link_libraries(im2rec ${BEGIN_WHOLE_ARCHIVE} mxnet ${END_WHOLE_ARCHIVE} ${mxnet_LINKER_LIBS} ${OpenCV_LIBS} dmlc)
+  if(MSVC)
+    target_link_libraries(im2rec mxnet)
+  else()
+    target_link_libraries(im2rec ${BEGIN_WHOLE_ARCHIVE} mxnet_static ${END_WHOLE_ARCHIVE})
+  endif()
+  target_link_libraries(im2rec
+    ${mxnet_LINKER_LIBS}
+    ${OpenCV_LIBS}
+    dmlc
+    ${nnvm_LINKER_LIBS}
+    ${pslite_LINKER_LIBS}
+    )
 
 Review comment:
   Can you explain this change? How is related to the original patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services