You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2019/12/24 10:28:18 UTC
Review Request 71939: RANGER-2678: RangerUgSyncRESTClient sets
password as username for basic auth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71939/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2678
https://issues.apache.org/jira/browse/RANGER-2678
Repository: ranger
Description
-------
**Problem Statement: **
RANGER-2591 Introduced changes to usersync (unix/ldap).
The following line is however broken
https://github.com/apache/ranger/blame/master/ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java#L83
getClient().addFilter(new HTTPBasicAuthFilter(getPassword(), getPassword()));
**Proposed Solution: **
it should be
getClient().addFilter(new HTTPBasicAuthFilter(getUsername(), getPassword()));
Diffs
-----
src/main/assembly/usersync.xml 220126cf8
ugsync/pom.xml 9e33d3d3e
ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java e4024a25a
Diff: https://reviews.apache.org/r/71939/diff/1/
Testing
-------
Tested the ranger usersync module and users are getting synced to ranger admin.
Thanks,
Pradeep Agrawal
Re: Review Request 71939: RANGER-2678: RangerUgSyncRESTClient sets
password as username for basic auth
Posted by Nikhil P <np...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71939/#review219104
-----------------------------------------------------------
Ship it!
Ship It!
- Nikhil P
On Dec. 24, 2019, 3:58 p.m., Pradeep Agrawal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71939/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2019, 3:58 p.m.)
>
>
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2678
> https://issues.apache.org/jira/browse/RANGER-2678
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement: **
> RANGER-2591 Introduced changes to usersync (unix/ldap).
>
> The following line is however broken
>
> https://github.com/apache/ranger/blame/master/ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java#L83
>
> getClient().addFilter(new HTTPBasicAuthFilter(getPassword(), getPassword()));
>
> **Proposed Solution: **
> it should be
>
> getClient().addFilter(new HTTPBasicAuthFilter(getUsername(), getPassword()));
>
>
> Diffs
> -----
>
> src/main/assembly/usersync.xml 220126cf8
> ugsync/pom.xml 9e33d3d3e
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java e4024a25a
>
>
> Diff: https://reviews.apache.org/r/71939/diff/1/
>
>
> Testing
> -------
>
> Tested the ranger usersync module and users are getting synced to ranger admin.
>
>
> Thanks,
>
> Pradeep Agrawal
>
>