You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/03 10:59:26 UTC
[GitHub] [airflow] feluelle opened a new pull request #7347: [AIRFLOW-XXXX]
Add pre-commit check for utf-8 file encoding
feluelle opened a new pull request #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347
Note: From Python 3.x onwards the explicit utf-8 header is no longer required. It is utf-8 encoded by default.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581467964
I think discussing it now took more time than implementing it :). I am all for intermediate solutions if they are super-simple to implement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581801117
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=h1) Report
> Merging [#7347](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5f7acb1f0df46794bf63a5cb4794d4cefaa0c391?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7347 +/- ##
==========================================
- Coverage 86.35% 86.06% -0.29%
==========================================
Files 871 871
Lines 40627 40627
==========================================
- Hits 35083 34967 -116
- Misses 5544 5660 +116
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/amazon/aws/operators/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9vcGVyYXRvcnMvY2xvdWRfZm9ybWF0aW9uLnB5) | `100% <ø> (ø)` | :arrow_up: |
| [...rflow/providers/mysql/operators/presto\_to\_mysql.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL3ByZXN0b190b19teXNxbC5weQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...flow/providers/amazon/aws/hooks/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9jbG91ZF9mb3JtYXRpb24ucHk=) | `96.77% <ø> (ø)` | :arrow_up: |
| [...ow/providers/amazon/aws/sensors/cloud\_formation.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9zZW5zb3JzL2Nsb3VkX2Zvcm1hdGlvbi5weQ==) | `100% <ø> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7347/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `70.21% <0%> (-23.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=footer). Last update [5f7acb1...d50b5bb](https://codecov.io/gh/apache/airflow/pull/7347?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581444279
However we should exclude vendor files from this for sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581788043
That should do it! ..now I think we should get this thing quickly merged as soon as it passes to avoid further rebases :P
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581619192
I think you need to apply the precommit in the next push @feluelle !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581443816
I think we can add it for now and replace with pyupgrade when it's ready. Pyupgrade has more things that it fixes but I see no problem with adding it now especially that it is built-in in one of the repos we have now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581422313
I want to do it using pyupgrade. https://github.com/PolideaInternal/airflow/issues/649 I don't know if we want to duplicate tools that do the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581464203
I don't know if adding magic comments with coding is a problem that is worth solving. It seems to me that if someone adds this comment it does not cause serious problems and we do not need a temporary solution. Instead of developing a temporary solution for a maximum of 2 weeks, you can make other contributions. I am not against this change. If you decide to finish it, I will gladly accept it. I just wanted to show the wider context of my change. Deleting the magic of comments is only an intermediate step, but it is not my goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581356967
Related to #7338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581786035
True. 🤦♂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7347: [AIRFLOW-XXXX]
Add pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581422313
I want to do it using pyupgrade: https://github.com/apache/airflow/pull/7343 I don't know if we want to duplicate tools that do the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7347: [AIRFLOW-XXXX] Add
pre-commit check for utf-8 file encoding
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7347: [AIRFLOW-XXXX] Add pre-commit check for utf-8 file encoding
URL: https://github.com/apache/airflow/pull/7347#issuecomment-581801557
Thanks @feluelle !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services