You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2023/03/08 07:49:41 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #8113: [Hotfix] refactor for PartialUpdateAvroPayload with delele constructor

danny0405 commented on code in PR #8113:
URL: https://github.com/apache/hudi/pull/8113#discussion_r1129073320


##########
hudi-common/src/main/java/org/apache/hudi/common/model/PartialUpdateAvroPayload.java:
##########
@@ -93,10 +93,6 @@ public PartialUpdateAvroPayload(GenericRecord record, Comparable orderingVal) {
     super(record, orderingVal);
   }
 
-  public PartialUpdateAvroPayload(Option<GenericRecord> record) {
-    super(record); // natural order
-  }
-

Review Comment:
   So why the natural order combining is removed? Can you elaborate a little more the use case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org