You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/23 17:20:21 UTC

[GitHub] [spark] sunchao commented on a change in pull request #30470: [SPARK-33495][BUILD] Remove commons-logging.jar's dependency

sunchao commented on a change in pull request #30470:
URL: https://github.com/apache/spark/pull/30470#discussion_r528870549



##########
File path: pom.xml
##########
@@ -1091,6 +1109,12 @@
         <artifactId>hadoop-client-runtime</artifactId>
         <version>${hadoop.version}</version>
         <scope>${hadoop.deps.scope}</scope>
+        <exclusions>
+          <exclusion>
+            <groupId>commons-logging</groupId>
+            <artifactId>commons-logging</artifactId>
+          </exclusion>
+        </exclusions>

Review comment:
       This is a runtime dependency for `hadoop-client-runtime`, so I'm not sure if we can remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org