You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2021/06/23 10:46:42 UTC
[arrow-rs] branch active_release updated: remove stale comment and
update unit tests (#472) (#487)
This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch active_release
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/active_release by this push:
new d851dec remove stale comment and update unit tests (#472) (#487)
d851dec is described below
commit d851decbabd5ff5f72af08602830199404fb08b4
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Wed Jun 23 06:46:36 2021 -0400
remove stale comment and update unit tests (#472) (#487)
Co-authored-by: Jiayu Liu <Ji...@users.noreply.github.com>
---
arrow/src/array/array_struct.rs | 24 ++----------------------
arrow/src/array/builder.rs | 24 ++----------------------
2 files changed, 4 insertions(+), 44 deletions(-)
diff --git a/arrow/src/array/array_struct.rs b/arrow/src/array/array_struct.rs
index 9c11b83..f721d35 100644
--- a/arrow/src/array/array_struct.rs
+++ b/arrow/src/array/array_struct.rs
@@ -362,28 +362,8 @@ mod tests {
.add_buffer(Buffer::from(&[1, 2, 0, 4].to_byte_slice()))
.build();
- assert_eq!(&expected_string_data, arr.column(0).data());
-
- // TODO: implement equality for ArrayData
- assert_eq!(expected_int_data.len(), arr.column(1).data().len());
- assert_eq!(
- expected_int_data.null_count(),
- arr.column(1).data().null_count()
- );
- assert_eq!(
- expected_int_data.null_bitmap(),
- arr.column(1).data().null_bitmap()
- );
- let expected_value_buf = expected_int_data.buffers()[0].clone();
- let actual_value_buf = arr.column(1).data().buffers()[0].clone();
- for i in 0..expected_int_data.len() {
- if !expected_int_data.is_null(i) {
- assert_eq!(
- expected_value_buf.as_slice()[i * 4..(i + 1) * 4],
- actual_value_buf.as_slice()[i * 4..(i + 1) * 4]
- );
- }
- }
+ assert_eq!(expected_string_data, *arr.column(0).data());
+ assert_eq!(expected_int_data, *arr.column(1).data());
}
#[test]
diff --git a/arrow/src/array/builder.rs b/arrow/src/array/builder.rs
index 53ff0c8..f54f90e 100644
--- a/arrow/src/array/builder.rs
+++ b/arrow/src/array/builder.rs
@@ -3050,28 +3050,8 @@ mod tests {
.add_buffer(Buffer::from_slice_ref(&[1, 2, 0, 4]))
.build();
- assert_eq!(&expected_string_data, arr.column(0).data());
-
- // TODO: implement equality for ArrayData
- assert_eq!(expected_int_data.len(), arr.column(1).data().len());
- assert_eq!(
- expected_int_data.null_count(),
- arr.column(1).data().null_count()
- );
- assert_eq!(
- expected_int_data.null_bitmap(),
- arr.column(1).data().null_bitmap()
- );
- let expected_value_buf = expected_int_data.buffers()[0].clone();
- let actual_value_buf = arr.column(1).data().buffers()[0].clone();
- for i in 0..expected_int_data.len() {
- if !expected_int_data.is_null(i) {
- assert_eq!(
- expected_value_buf.as_slice()[i * 4..(i + 1) * 4],
- actual_value_buf.as_slice()[i * 4..(i + 1) * 4]
- );
- }
- }
+ assert_eq!(expected_string_data, *arr.column(0).data());
+ assert_eq!(expected_int_data, *arr.column(1).data());
}
#[test]