You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by "Daniel.Sun" <su...@apache.org> on 2017/11/11 15:24:06 UTC
[VOTE] Release Apache Groovy 2.6.0-alpha-2
Dear community,
I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
This release includes 10 bug fixes/improvements as outlined in the
changelog:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
Tag:
https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
The artifacts to be voted on are located as follows (r23058).
Source release:
https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
Convenience binaries:
https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
Release artifacts are signed with a key from the following file:
https://dist.apache.org/repos/dist/dev/groovy/KEYS
Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.
[ ] +1 Release Apache Groovy 2.6.0-alpha-2
[ ] 0 I don't have a strong opinion about this, but I assume it's ok
[ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
Here is my vote:
+1 (binding)
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Cédric Champeau <ce...@gmail.com>.
You can use version 10.1.2 of the build scan plugin. But note that this is
NOT specific to build scans. Any plugin applied that would be a bit old
compared to the version that you use to generate the wrapper, would
probably fail the build the same way: what we are doing is a dirty
workaround for the fact (again) that the Gradle wrapper is not blessed by
the foundation (it should, really). So what happens is that you use a much
more recent version of a local install of Gradle, than the one the build
accepts. And your version is of course _not_ compatible with the one that
has been checked in in `wrapper.properties`. This is **exactly** why the
wrapper exists and **must** be checked in the sources. So unless you
install the very same version than the one defined in the
wrapper.properties to generate the wrapper (which is pointless), you are in
a danger zone that can fail. It has nothing to do with the build scan
plugin. It is about build reproducibility. And I find it sad that we always
have to fight to get this in.
2017-11-13 9:58 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
> Hi,
>
> I was trying to build from source with the source bundle, but it seems you
> can't generate the wrapper from a recent version of Gradle.
> I have version 4.3.1, and when I try to launch gradle wrapper, to first
> create the appropriate wrapper, I get the following errors:
>
> $ gradle wrapper
>
>
> FAILURE: Build failed with an exception.
>
>
> * Where:
>
> Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle'
> line: 53
>
>
> * What went wrong:
>
> An exception occurred applying plugin request [id:
> 'com.gradle.build-scan', version: '1.6']
>
> > Failed to apply plugin [id 'com.gradle.build-scan']
>
> > This version of Gradle requires version 1.8.0 of the build scan
> plugin or later.
>
> Please see https://gradle.com/scans/help/gradle-incompatible-plugin-
> version for more information.
>
>
> * Try:
>
> Run with *--stacktrace* option to get the stack trace. Run with *--info*
> or *--debug* option to get more log output.
>
>
> * Get more help at https://help.gradle.org
>
>
> Which might also be why Cédric committed a change related to the build
> scan plugin?
>
> Guillaume
>
> On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <gr...@gmail.com>
> wrote:
>
>> +1
>>
>> On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <su...@apache.org> wrote:
>> > Dear community,
>> >
>> > I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>> >
>> > This release includes 10 bug fixes/improvements as outlined in the
>> > changelog:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318123&version=12341386
>> >
>> > Tag:
>> > https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>> ;h=refs/tags/GROOVY_2_6_0_ALPHA_2
>> > Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>> >
>> > The artifacts to be voted on are located as follows (r23058).
>> > Source release:
>> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
>> > Convenience binaries:
>> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/
>> distribution
>> >
>> > Release artifacts are signed with a key from the following file:
>> > https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >
>> > Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>> >
>> > The vote is open for the next 72 hours and passes if a majority of at
>> least
>> > three +1 PMC votes are cast.
>> >
>> > [ ] +1 Release Apache Groovy 2.6.0-alpha-2
>> > [ ] 0 I don't have a strong opinion about this, but I assume it's ok
>> > [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>> >
>> > Here is my vote:
>> >
>> > +1 (binding)
>> >
>> >
>> >
>> >
>> > --
>> > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>>
>>
>>
>> --
>> Graeme Rocher
>>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge <http://twitter.com/glaforge> / Google+
> <https://plus.google.com/u/0/114130972232398734985/posts>
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Daniel Sun <re...@hotmail.com>.
Hi Jochen,
Thanks for your setting aside some time to vote :)
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Jochen Theodorou <bl...@gmx.org>.
I was not asked, but I still vote +1 (binding)
Am 14.11.2017 um 11:48 schrieb Daniel Sun:
> Hi Paul,
>
> Your vote is ?
>
> Cheers,
> Daniel.Sun
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Daniel Sun <re...@hotmail.com>.
Hi Paul,
Your vote is ?
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Cédric Champeau <ce...@gmail.com>.
+1 (binding)
2017-11-14 15:58 GMT+01:00 Konstantin Boudnik <co...@apache.org>:
> Paul, while the custom wrapper is a completely valid concern, the same
> version of it has hold well since Gradle 1.8 IIRC. So, the overhead is
> pretty small.
> --
> Regards,
> Cos
>
> On November 14, 2017 7:29:36 AM GMT+03:00, Paul King <pa...@asert.com.au>
> wrote:
> >I tweaked the build files and README so that the bootstrapping
> >instructions
> >now read:
> >
> >gradle -b wrapper.gradle wrapper
> >
> >Since that file has no plugins, it should hopefully make us much more
> >Gradle version resilient.
> >
> >It doesn't mean we might not want to consider Cos' proposal since (at
> >the
> >expense of having to keep updating the custom wrapper) it would
> >eliminate
> >the need to have gradle installed for bootstrapping.
> >
> >Also, it doesn't stop us from continuing to ask for permission to
> >include
> >the wrapper so that builders from source aren't second class citizens -
> >needing the extra download. Perhaps that should be a section in our
> >next
> >board report?
> >
> >Anyway, we should get those changes for the next prepared releases.
> >
> >Cheers, Paul.
> >
> >
> >On Tue, Nov 14, 2017 at 4:18 AM, Konstantin Boudnik <co...@apache.org>
> >wrote:
> >
> >> Current release includes a binary file (gradle/wrapper/*jar), which
> >> isn't compatible with Apache release policy (ie source-only
> >releases).
> >> In all honestly, this isn't the first release with the same issue. I
> >> was talking about it for too long and I am sorry I didn't address
> >this
> >> issue earlier.
> >>
> >> Here's https://issues.apache.org/jira/browse/GROOVY-8378 that has the
> >> patch for the issue. I don't think we should block this release, but
> >> let's make backport it into the next one, if there's no objections.
> >>
> >> Incidentally, I can't assign the ticket to myself for whatever
> >reason.
> >> But the patch is there ;) Thanks!
> >> --
> >> With regards,
> >> Konstantin (Cos) Boudnik
> >> 2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622
> >>
> >> Disclaimer: Opinions expressed in this email are those of the author,
> >> and do not necessarily represent the views of any company the author
> >> might be affiliated with at the moment of writing.
> >>
> >>
> >> On Mon, Nov 13, 2017 at 5:40 PM, Cédric Champeau
> >> <ce...@gmail.com> wrote:
> >> > This will not always be possible. The source zip will live for
> >years. You
> >> > can only do this at release time, and there's nothing that
> >guarantees
> >> that
> >> > all plugins will all be compatible with the latest version of
> >Gradle at
> >> the
> >> > moment you release for a branch that uses an old version. It's just
> >a
> >> > miracle it works. Instead, let's make our point to the foundation:
> >the
> >> > wrapper MUST be endorsed.
> >> >
> >> > 2017-11-13 15:38 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
> >> >>
> >> >> I'm voting +1
> >> >>
> >> >> But let's get sure we can build from source the next time when
> >someone
> >> has
> >> >> a recent version of Gradle installed locally.
> >> >> At the very minimum, we should indicate in the README that we have
> >to
> >> use
> >> >> some range of Gradle version for generating the wrapper in the
> >first
> >> place.
> >> >>
> >> >> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org>
> >wrote:
> >> >>>
> >> >>> Hi Guillaume,
> >> >>>
> >> >>> I've understood what you mean :-)
> >> >>>
> >> >>> As to the version of plugin, we can not satisfy everyone
> >because
> >> >>> gradle 3+ and gradle 4+ requires different versions of plugin. So
> >I
> >> >>> sugguest
> >> >>> we should clarify the requirement of gradle version, which must
> >be
> >> 3.5.1
> >> >>> to
> >> >>> generate the wrapper and build Apache Groovy from source.
> >> >>>
> >> >>> At last, I want to know, your vote is ? ;-)
> >> >>>
> >> >>>
> >> >>> Cheers,
> >> >>> Daniel.Sun
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> Sent from:
> >http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Guillaume Laforge
> >> >> Apache Groovy committer & PMC Vice-President
> >> >> Developer Advocate @ Google Cloud Platform
> >> >>
> >> >> Blog: http://glaforge.appspot.com/
> >> >> Social: @glaforge / Google+
> >> >
> >> >
> >>
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Konstantin Boudnik <co...@apache.org>.
Paul, while the custom wrapper is a completely valid concern, the same version of it has hold well since Gradle 1.8 IIRC. So, the overhead is pretty small.
--
Regards,
Cos
On November 14, 2017 7:29:36 AM GMT+03:00, Paul King <pa...@asert.com.au> wrote:
>I tweaked the build files and README so that the bootstrapping
>instructions
>now read:
>
>gradle -b wrapper.gradle wrapper
>
>Since that file has no plugins, it should hopefully make us much more
>Gradle version resilient.
>
>It doesn't mean we might not want to consider Cos' proposal since (at
>the
>expense of having to keep updating the custom wrapper) it would
>eliminate
>the need to have gradle installed for bootstrapping.
>
>Also, it doesn't stop us from continuing to ask for permission to
>include
>the wrapper so that builders from source aren't second class citizens -
>needing the extra download. Perhaps that should be a section in our
>next
>board report?
>
>Anyway, we should get those changes for the next prepared releases.
>
>Cheers, Paul.
>
>
>On Tue, Nov 14, 2017 at 4:18 AM, Konstantin Boudnik <co...@apache.org>
>wrote:
>
>> Current release includes a binary file (gradle/wrapper/*jar), which
>> isn't compatible with Apache release policy (ie source-only
>releases).
>> In all honestly, this isn't the first release with the same issue. I
>> was talking about it for too long and I am sorry I didn't address
>this
>> issue earlier.
>>
>> Here's https://issues.apache.org/jira/browse/GROOVY-8378 that has the
>> patch for the issue. I don't think we should block this release, but
>> let's make backport it into the next one, if there's no objections.
>>
>> Incidentally, I can't assign the ticket to myself for whatever
>reason.
>> But the patch is there ;) Thanks!
>> --
>> With regards,
>> Konstantin (Cos) Boudnik
>> 2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622
>>
>> Disclaimer: Opinions expressed in this email are those of the author,
>> and do not necessarily represent the views of any company the author
>> might be affiliated with at the moment of writing.
>>
>>
>> On Mon, Nov 13, 2017 at 5:40 PM, Cédric Champeau
>> <ce...@gmail.com> wrote:
>> > This will not always be possible. The source zip will live for
>years. You
>> > can only do this at release time, and there's nothing that
>guarantees
>> that
>> > all plugins will all be compatible with the latest version of
>Gradle at
>> the
>> > moment you release for a branch that uses an old version. It's just
>a
>> > miracle it works. Instead, let's make our point to the foundation:
>the
>> > wrapper MUST be endorsed.
>> >
>> > 2017-11-13 15:38 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
>> >>
>> >> I'm voting +1
>> >>
>> >> But let's get sure we can build from source the next time when
>someone
>> has
>> >> a recent version of Gradle installed locally.
>> >> At the very minimum, we should indicate in the README that we have
>to
>> use
>> >> some range of Gradle version for generating the wrapper in the
>first
>> place.
>> >>
>> >> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org>
>wrote:
>> >>>
>> >>> Hi Guillaume,
>> >>>
>> >>> I've understood what you mean :-)
>> >>>
>> >>> As to the version of plugin, we can not satisfy everyone
>because
>> >>> gradle 3+ and gradle 4+ requires different versions of plugin. So
>I
>> >>> sugguest
>> >>> we should clarify the requirement of gradle version, which must
>be
>> 3.5.1
>> >>> to
>> >>> generate the wrapper and build Apache Groovy from source.
>> >>>
>> >>> At last, I want to know, your vote is ? ;-)
>> >>>
>> >>>
>> >>> Cheers,
>> >>> Daniel.Sun
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Sent from:
>http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>> >>
>> >>
>> >>
>> >>
>> >> --
>> >> Guillaume Laforge
>> >> Apache Groovy committer & PMC Vice-President
>> >> Developer Advocate @ Google Cloud Platform
>> >>
>> >> Blog: http://glaforge.appspot.com/
>> >> Social: @glaforge / Google+
>> >
>> >
>>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Paul King <pa...@asert.com.au>.
I tweaked the build files and README so that the bootstrapping instructions
now read:
gradle -b wrapper.gradle wrapper
Since that file has no plugins, it should hopefully make us much more
Gradle version resilient.
It doesn't mean we might not want to consider Cos' proposal since (at the
expense of having to keep updating the custom wrapper) it would eliminate
the need to have gradle installed for bootstrapping.
Also, it doesn't stop us from continuing to ask for permission to include
the wrapper so that builders from source aren't second class citizens -
needing the extra download. Perhaps that should be a section in our next
board report?
Anyway, we should get those changes for the next prepared releases.
Cheers, Paul.
On Tue, Nov 14, 2017 at 4:18 AM, Konstantin Boudnik <co...@apache.org> wrote:
> Current release includes a binary file (gradle/wrapper/*jar), which
> isn't compatible with Apache release policy (ie source-only releases).
> In all honestly, this isn't the first release with the same issue. I
> was talking about it for too long and I am sorry I didn't address this
> issue earlier.
>
> Here's https://issues.apache.org/jira/browse/GROOVY-8378 that has the
> patch for the issue. I don't think we should block this release, but
> let's make backport it into the next one, if there's no objections.
>
> Incidentally, I can't assign the ticket to myself for whatever reason.
> But the patch is there ;) Thanks!
> --
> With regards,
> Konstantin (Cos) Boudnik
> 2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622
>
> Disclaimer: Opinions expressed in this email are those of the author,
> and do not necessarily represent the views of any company the author
> might be affiliated with at the moment of writing.
>
>
> On Mon, Nov 13, 2017 at 5:40 PM, Cédric Champeau
> <ce...@gmail.com> wrote:
> > This will not always be possible. The source zip will live for years. You
> > can only do this at release time, and there's nothing that guarantees
> that
> > all plugins will all be compatible with the latest version of Gradle at
> the
> > moment you release for a branch that uses an old version. It's just a
> > miracle it works. Instead, let's make our point to the foundation: the
> > wrapper MUST be endorsed.
> >
> > 2017-11-13 15:38 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
> >>
> >> I'm voting +1
> >>
> >> But let's get sure we can build from source the next time when someone
> has
> >> a recent version of Gradle installed locally.
> >> At the very minimum, we should indicate in the README that we have to
> use
> >> some range of Gradle version for generating the wrapper in the first
> place.
> >>
> >> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org> wrote:
> >>>
> >>> Hi Guillaume,
> >>>
> >>> I've understood what you mean :-)
> >>>
> >>> As to the version of plugin, we can not satisfy everyone because
> >>> gradle 3+ and gradle 4+ requires different versions of plugin. So I
> >>> sugguest
> >>> we should clarify the requirement of gradle version, which must be
> 3.5.1
> >>> to
> >>> generate the wrapper and build Apache Groovy from source.
> >>>
> >>> At last, I want to know, your vote is ? ;-)
> >>>
> >>>
> >>> Cheers,
> >>> Daniel.Sun
> >>>
> >>>
> >>>
> >>> --
> >>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
> >>
> >>
> >>
> >>
> >> --
> >> Guillaume Laforge
> >> Apache Groovy committer & PMC Vice-President
> >> Developer Advocate @ Google Cloud Platform
> >>
> >> Blog: http://glaforge.appspot.com/
> >> Social: @glaforge / Google+
> >
> >
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Konstantin Boudnik <co...@apache.org>.
Current release includes a binary file (gradle/wrapper/*jar), which
isn't compatible with Apache release policy (ie source-only releases).
In all honestly, this isn't the first release with the same issue. I
was talking about it for too long and I am sorry I didn't address this
issue earlier.
Here's https://issues.apache.org/jira/browse/GROOVY-8378 that has the
patch for the issue. I don't think we should block this release, but
let's make backport it into the next one, if there's no objections.
Incidentally, I can't assign the ticket to myself for whatever reason.
But the patch is there ;) Thanks!
--
With regards,
Konstantin (Cos) Boudnik
2CAC 8312 4870 D885 8616 6115 220F 6980 1F27 E622
Disclaimer: Opinions expressed in this email are those of the author,
and do not necessarily represent the views of any company the author
might be affiliated with at the moment of writing.
On Mon, Nov 13, 2017 at 5:40 PM, Cédric Champeau
<ce...@gmail.com> wrote:
> This will not always be possible. The source zip will live for years. You
> can only do this at release time, and there's nothing that guarantees that
> all plugins will all be compatible with the latest version of Gradle at the
> moment you release for a branch that uses an old version. It's just a
> miracle it works. Instead, let's make our point to the foundation: the
> wrapper MUST be endorsed.
>
> 2017-11-13 15:38 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
>>
>> I'm voting +1
>>
>> But let's get sure we can build from source the next time when someone has
>> a recent version of Gradle installed locally.
>> At the very minimum, we should indicate in the README that we have to use
>> some range of Gradle version for generating the wrapper in the first place.
>>
>> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org> wrote:
>>>
>>> Hi Guillaume,
>>>
>>> I've understood what you mean :-)
>>>
>>> As to the version of plugin, we can not satisfy everyone because
>>> gradle 3+ and gradle 4+ requires different versions of plugin. So I
>>> sugguest
>>> we should clarify the requirement of gradle version, which must be 3.5.1
>>> to
>>> generate the wrapper and build Apache Groovy from source.
>>>
>>> At last, I want to know, your vote is ? ;-)
>>>
>>>
>>> Cheers,
>>> Daniel.Sun
>>>
>>>
>>>
>>> --
>>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>>
>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge / Google+
>
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by "Daniel.Sun" <su...@apache.org>.
Hi Cédric,
Your vote is ?
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Cédric Champeau <ce...@gmail.com>.
This will not always be possible. The source zip will live for years. You
can only do this at release time, and there's nothing that guarantees that
all plugins will all be compatible with the latest version of Gradle at the
moment you release for a branch that uses an old version. It's just a
miracle it works. Instead, let's make our point to the foundation: the
wrapper MUST be endorsed.
2017-11-13 15:38 GMT+01:00 Guillaume Laforge <gl...@gmail.com>:
> I'm voting +1
>
> But let's get sure we can build from source the next time when someone has
> a recent version of Gradle installed locally.
> At the very minimum, we should indicate in the README that we have to use
> some range of Gradle version for generating the wrapper in the first place.
>
> On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org> wrote:
>
>> Hi Guillaume,
>>
>> I've understood what you mean :-)
>>
>> As to the version of plugin, we can not satisfy everyone because
>> gradle 3+ and gradle 4+ requires different versions of plugin. So I
>> sugguest
>> we should clarify the requirement of gradle version, which must be 3.5.1
>> to
>> generate the wrapper and build Apache Groovy from source.
>>
>> At last, I want to know, your vote is ? ;-)
>>
>>
>> Cheers,
>> Daniel.Sun
>>
>>
>>
>> --
>> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge <http://twitter.com/glaforge> / Google+
> <https://plus.google.com/u/0/114130972232398734985/posts>
>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Guillaume Laforge <gl...@gmail.com>.
I'm voting +1
But let's get sure we can build from source the next time when someone has
a recent version of Gradle installed locally.
At the very minimum, we should indicate in the README that we have to use
some range of Gradle version for generating the wrapper in the first place.
On Mon, Nov 13, 2017 at 2:53 PM, Daniel.Sun <su...@apache.org> wrote:
> Hi Guillaume,
>
> I've understood what you mean :-)
>
> As to the version of plugin, we can not satisfy everyone because
> gradle 3+ and gradle 4+ requires different versions of plugin. So I
> sugguest
> we should clarify the requirement of gradle version, which must be 3.5.1 to
> generate the wrapper and build Apache Groovy from source.
>
> At last, I want to know, your vote is ? ;-)
>
>
> Cheers,
> Daniel.Sun
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform
Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by "Daniel.Sun" <su...@apache.org>.
Hi Guillaume,
I've understood what you mean :-)
As to the version of plugin, we can not satisfy everyone because
gradle 3+ and gradle 4+ requires different versions of plugin. So I sugguest
we should clarify the requirement of gradle version, which must be 3.5.1 to
generate the wrapper and build Apache Groovy from source.
At last, I want to know, your vote is ? ;-)
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Guillaume Laforge <gl...@gmail.com>.
Hi Daniel,
I'm not building Groovy with Gradle 4+.
I only wanted to generate the wrapper with Gradle 4.3.1, which was the
version I had installed locally.
As you know, we can't ship the wrapper with our source distribution.
And it means that someone with Gradle 4+ on his machine cannot build the
source distribution out of the box.
But as I said in my other email, at least for the wrapper task generation,
it was really just related to the problem with the plugin version.
Otherwise, we can indeed use Gradle 4.x to create the wrapper, and then use
whichever version used by the wrapper properties, which is fine.
But as is, we can't build from source, since we can't generate the wrapper.
It's not a big showstopper, and I think we can proceed with the release, as
otherwise, the convenience binaries or the custom-built (with the right
build scan plugin version) is fine.
Hope this clarifies my point. Sorry if this wasn't clear.
Guillaume
On Mon, Nov 13, 2017 at 1:00 PM, Daniel Sun <re...@hotmail.com> wrote:
> Hi Guillaume,
>
> Gradle 4+ does not support building Groovy well, so please check via
> "gradlew clean dist"(note: use gradlew instead of gradle).
>
> Cheers,
> Daniel.Sun
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform
Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Daniel Sun <re...@hotmail.com>.
Hi Guillaume,
Gradle 4+ does not support building Groovy well, so please check via
"gradlew clean dist"(note: use gradlew instead of gradle).
Cheers,
Daniel.Sun
--
Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Guillaume Laforge <gl...@gmail.com>.
But apart from this build-from-source issue, if I change the version of the
plugin I mentioned below, then I can successfully build the project and run
things like the Groovy console.
Guillaume
On Mon, Nov 13, 2017 at 9:58 AM, Guillaume Laforge <gl...@gmail.com>
wrote:
> Hi,
>
> I was trying to build from source with the source bundle, but it seems you
> can't generate the wrapper from a recent version of Gradle.
> I have version 4.3.1, and when I try to launch gradle wrapper, to first
> create the appropriate wrapper, I get the following errors:
>
> $ gradle wrapper
>
>
> FAILURE: Build failed with an exception.
>
>
> * Where:
>
> Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle'
> line: 53
>
>
> * What went wrong:
>
> An exception occurred applying plugin request [id:
> 'com.gradle.build-scan', version: '1.6']
>
> > Failed to apply plugin [id 'com.gradle.build-scan']
>
> > This version of Gradle requires version 1.8.0 of the build scan
> plugin or later.
>
> Please see https://gradle.com/scans/help/gradle-incompatible-plugin-
> version for more information.
>
>
> * Try:
>
> Run with *--stacktrace* option to get the stack trace. Run with *--info*
> or *--debug* option to get more log output.
>
>
> * Get more help at https://help.gradle.org
>
>
> Which might also be why Cédric committed a change related to the build
> scan plugin?
>
> Guillaume
>
> On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <gr...@gmail.com>
> wrote:
>
>> +1
>>
>> On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <su...@apache.org> wrote:
>> > Dear community,
>> >
>> > I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>> >
>> > This release includes 10 bug fixes/improvements as outlined in the
>> > changelog:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12318123&version=12341386
>> >
>> > Tag:
>> > https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag
>> ;h=refs/tags/GROOVY_2_6_0_ALPHA_2
>> > Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>> >
>> > The artifacts to be voted on are located as follows (r23058).
>> > Source release:
>> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
>> > Convenience binaries:
>> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/
>> distribution
>> >
>> > Release artifacts are signed with a key from the following file:
>> > https://dist.apache.org/repos/dist/dev/groovy/KEYS
>> >
>> > Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>> >
>> > The vote is open for the next 72 hours and passes if a majority of at
>> least
>> > three +1 PMC votes are cast.
>> >
>> > [ ] +1 Release Apache Groovy 2.6.0-alpha-2
>> > [ ] 0 I don't have a strong opinion about this, but I assume it's ok
>> > [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>> >
>> > Here is my vote:
>> >
>> > +1 (binding)
>> >
>> >
>> >
>> >
>> > --
>> > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>>
>>
>>
>> --
>> Graeme Rocher
>>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Developer Advocate @ Google Cloud Platform
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge <http://twitter.com/glaforge> / Google+
> <https://plus.google.com/u/0/114130972232398734985/posts>
>
--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform
Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Guillaume Laforge <gl...@gmail.com>.
Hi,
I was trying to build from source with the source bundle, but it seems you
can't generate the wrapper from a recent version of Gradle.
I have version 4.3.1, and when I try to launch gradle wrapper, to first
create the appropriate wrapper, I get the following errors:
$ gradle wrapper
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/glaforge/Downloads/groovy-2.6.0-alpha-2/build.gradle'
line: 53
* What went wrong:
An exception occurred applying plugin request [id: 'com.gradle.build-scan',
version: '1.6']
> Failed to apply plugin [id 'com.gradle.build-scan']
> This version of Gradle requires version 1.8.0 of the build scan plugin
or later.
Please see
https://gradle.com/scans/help/gradle-incompatible-plugin-version for more
information.
* Try:
Run with *--stacktrace* option to get the stack trace. Run with *--info* or
*--debug* option to get more log output.
* Get more help at https://help.gradle.org
Which might also be why Cédric committed a change related to the build scan
plugin?
Guillaume
On Sun, Nov 12, 2017 at 5:04 PM, Graeme Rocher <gr...@gmail.com>
wrote:
> +1
>
> On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <su...@apache.org> wrote:
> > Dear community,
> >
> > I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
> >
> > This release includes 10 bug fixes/improvements as outlined in the
> > changelog:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12341386
> >
> > Tag:
> > https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> > Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
> >
> > The artifacts to be voted on are located as follows (r23058).
> > Source release:
> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> > Convenience binaries:
> > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
> >
> > Release artifacts are signed with a key from the following file:
> > https://dist.apache.org/repos/dist/dev/groovy/KEYS
> >
> > Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> least
> > three +1 PMC votes are cast.
> >
> > [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> > [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> > [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> >
> >
> >
> > --
> > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>
>
>
> --
> Graeme Rocher
>
--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform
Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Graeme Rocher <gr...@gmail.com>.
+1
On Sat, Nov 11, 2017 at 4:24 PM, Daniel.Sun <su...@apache.org> wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
--
Graeme Rocher
Re: [VOTE] Release Apache Groovy 2.6.0-alpha-2
Posted by Paul King <pa...@asert.com.au>.
+1
Builds/tests from src (with the already mentioned caveat about required
gradle version for bootstrapping)
Checked checksums/signatures for all four zips
Ran several scripts from console
Before the next release 22.6 release, and specifically just for 2.6 but not
master, we should add a note about -PuseAntlr4 in README.adoc when building
from source. There's a note in the README.adoc file in the antlr4
subdirectory but users won't look in there by default.
We should mention the gradle bootstrap issue in the release email - no
change needed for README.adoc for next time since it shouldn't be an issue
any more.
Cheers, Paul.
On Sun, Nov 12, 2017 at 1:24 AM, Daniel.Sun <su...@apache.org> wrote:
> Dear community,
>
> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-2 release!
>
> This release includes 10 bug fixes/improvements as outlined in the
> changelog:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12318123&version=12341386
>
> Tag:
> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=
> tag;h=refs/tags/GROOVY_2_6_0_ALPHA_2
> Tag commit id: 3c37e8ce66613901f1b523b0519fb6ba51676270
>
> The artifacts to be voted on are located as follows (r23058).
> Source release:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/sources
> Convenience binaries:
> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-2/distribution
>
> Release artifacts are signed with a key from the following file:
> https://dist.apache.org/repos/dist/dev/groovy/KEYS
>
> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-2.
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> [ ] +1 Release Apache Groovy 2.6.0-alpha-2
> [ ] 0 I don't have a strong opinion about this, but I assume it's ok
> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-2 because...
>
> Here is my vote:
>
> +1 (binding)
>
>
>
>
> --
> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
>