[PR] fix: enable infoset and infoset-diff views from any file context during debugging [daffodil-vscode]

["social5h3ll (via GitHub)" <gi...@apache.org>]

social5h3ll opened a new pull request, #1704:
URL: https://github.com/apache/daffodil-vscode/pull/1704

   ## Fixes: apache/daffodil-vscode#1703
   
   ### Problem
   While parsing a file, the Daffodil helper tab does not list the option to open the Infoset or Infoset Diff View unless the active tab is the DFDL schema file. This is because the `infoset.display` and `infoset.diff` commands are gated by `editorLangId == 'dfdl'` — they only appear when a DFDL schema file is the active editor.
   
   This means if a user is debugging and switches to a data file or any other file type, they cannot access the infoset views from the Daffodil helper.
   
   ### Root Cause
   In `package.json`, the command enablement and menu `when` clauses both included `editorLangId == 'dfdl'`:
   
   ```json
   "enablement": "inDebugMode && editorLangId == 'dfdl'"
   "when": "inDebugMode && editorLangId == 'dfdl'"
   ```
   
   This condition restricts the infoset commands to DFDL schema editors only, even though the infoset data is available throughout the debug session.
   
   ### Fix
   Remove `&& editorLangId == 'dfdl'` from both the `enablement` field and the `editor/title` menu `when` clause for both `infoset.display` and `infoset.diff` commands.
   
   After the fix:
   - `enablement`: `inDebugMode`
   - `when`: `inDebugMode`
   
   This keeps the commands available only during active debug sessions but removes the schema-file-only restriction, so users can open the infoset views from any file context while debugging.
   
   ### Acceptance Criteria
   - [x] Infoset view command available from Daffodil helper during debugging regardless of active file type
   - [x] Infoset diff view command available from Daffodil helper during debugging regardless of active file type
   - [x] Commands remain gated by `inDebugMode` (not available outside debug sessions)
   
   Closes #1703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: enable infoset and infoset-diff views from any file context during debugging [daffodil-vscode]

["social5h3ll (via GitHub)" <gi...@apache.org>]

social5h3ll closed pull request #1704: fix: enable infoset and infoset-diff views from any file context during debugging
URL: https://github.com/apache/daffodil-vscode/pull/1704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org