You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/02/25 00:05:46 UTC

[kudu-CR] Add test for implicit partitions

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6153

to review the following change.

Change subject: Add test for implicit partitions
......................................................................

Add test for implicit partitions

A question came up on the mailing list about the behavior of the table
creator when not specifying bounds, and I couldn't find a unit test
covering it. This adds such a test, and it _does_ look like we are
consistent with the docs in client.h.

Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
---
M src/kudu/client/client-test.cc
1 file changed, 87 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/6153/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] Add test for implicit partitions

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: Add test for implicit partitions
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS2, Line 664: specifing
nit: specifying


PS2, Line 668: &
nit: We can capture nothing.


PS2, Line 679: gscoped_ptr
nit: unique_ptr here and below


-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] Add test for implicit partitions

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6153

to look at the new patch set (#3).

Change subject: Add test for implicit partitions
......................................................................

Add test for implicit partitions

A question came up on the mailing list about the behavior of the table
creator when not specifying bounds, and I couldn't find a unit test
covering it. This adds such a test, and it _does_ look like we are
consistent with the docs in client.h.

Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
---
M src/kudu/client/client-test.cc
1 file changed, 85 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/6153/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Add test for implicit partitions

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.

Change subject: Add test for implicit partitions
......................................................................


Abandoned

This is well covered by AlterTableTest::TestAddRangePartitionConflictExhaustive

-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Add test for implicit partitions

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Add test for implicit partitions
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 672:     CHECK_OK(builder.Build(&tokens));
ASSERT_OK?


PS2, Line 689:       unique_ptr<KuduTableAlterer> alterer(client_->NewTableAlterer(table_name));
             :       ASSERT_OK(alterer->DropRangePartition(schema_.NewRow(), schema_.NewRow())->Alter());
             :       ASSERT_EQ(0, count_tablets(table.get()));
What is the purpose of this part of each subtest?


-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR] Add test for implicit partitions

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Add test for implicit partitions
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6153/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS2, Line 664: specifing
> nit: specifying
Done


PS2, Line 668: &
> nit: We can capture nothing.
Done


Line 672:     CHECK_OK(builder.Build(&tokens));
> ASSERT_OK?
ASSERT_OK only works in functions returning void.


PS2, Line 679: gscoped_ptr
> nit: unique_ptr here and below
Done


PS2, Line 689:       unique_ptr<KuduTableAlterer> alterer(client_->NewTableAlterer(table_name));
             :       ASSERT_OK(alterer->DropRangePartition(schema_.NewRow(), schema_.NewRow())->Alter());
             :       ASSERT_EQ(0, count_tablets(table.get()));
> What is the purpose of this part of each subtest?
This is one way to ensure that the implicit tablets are actually 'unbounded'.  If they had some other bound, dropping them via empty rows would fail.


-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] Add test for implicit partitions

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Add test for implicit partitions
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Add test for implicit partitions

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).

Change subject: Add test for implicit partitions
......................................................................

Add test for implicit partitions

A question came up on the mailing list about the behavior of the table
creator when not specifying bounds, and I couldn't find a unit test
covering it. This adds such a test, and it _does_ look like we are
consistent with the docs in client.h.

Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
---
M src/kudu/client/client-test.cc
1 file changed, 85 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/6153/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6153
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I53e370c836e00a6bdc724cc63843b6d25e3b659e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>