[GitHub] [nifi] turcsanyip commented on a change in pull request #4746: NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

[GitBox <gi...@apache.org>]

turcsanyip commented on a change in pull request #4746:
URL: https://github.com/apache/nifi/pull/4746#discussion_r557661186



##########
File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestStandardPreparedQuery.java
##########
@@ -309,6 +309,18 @@ public void testVariableImpacted() {
         assertTrue(Query.prepare("${anyMatchingAttribute('a.*'):equals('hello')}").getVariableImpact().isImpacted("attr"));
     }
 
+    @Test
+    public void testIsExpressionLanguagePresent() {
+        assertFalse(Query.prepare("value").isExpressionLanguagePresent());
+        assertFalse(Query.prepare("").isExpressionLanguagePresent());
+

Review comment:
       @sjyang18 Thanks for your review.
   I added further test cases based on your suggestions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org