You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2013/11/08 18:02:18 UTC
[jira] [Resolved] (HTTPCLIENT-1433) DefaultClientConnectionOperator
instance check inconsistent with explicit cast
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-1433.
-------------------------------------------
Resolution: Duplicate
Fix Version/s: 4.3.2
Duplicate of HTTPCLIENT-1431.
Oleg
> DefaultClientConnectionOperator instance check inconsistent with explicit cast
> ------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1433
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1433
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient
> Affects Versions: 4.3.1
> Environment: exists in all platforms.
> Reporter: jason mathews
> Fix For: 4.3.2
>
>
> Class checks for LayeredConnectionSocketFactory instance then casts to SchemeLayeredSocketFactory at line 214.
> Assertion check needs to be for SchemeLayeredSocketFactory not LayeredConnectionSocketFactory in DefaultClientConnectionOperator.updateSecureConnection().
> package org.apache.http.impl.conn;
> class DefaultClientConnectionOperator
> public void updateSecureConnection(...) {
> ...
> // line 214
> Asserts.check(schm.getSchemeSocketFactory() instanceof LayeredConnectionSocketFactory,
> "Socket factory must implement SchemeLayeredSocketFactory");
> final SchemeLayeredSocketFactory lsf = (SchemeLayeredSocketFactory) schm.getSchemeSocketFactory();
> }
> Fix:
> Asserts.check(schm.getSchemeSocketFactory() instanceof SchemeLayeredSocketFactory,
> "Socket factory must implement SchemeLayeredSocketFactory");
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org