You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2021/04/20 15:51:49 UTC

[tinkerpop] 01/01: Removed worker pool configuration given fix to TINKERPOP-2550 that fixes deadlock issue which typically occurred in low resource environments like travis CTR

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch travis-fix
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit e7010e193cd30eb432f0838f53c835014d484086
Author: Stephen Mallette <st...@amazon.com>
AuthorDate: Tue Apr 20 11:49:09 2021 -0400

    Removed worker pool configuration given fix to TINKERPOP-2550 that fixes deadlock issue which typically occurred in low resource environments like travis CTR
---
 .../org/apache/tinkerpop/gremlin/server/TestClientFactory.java     | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/TestClientFactory.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/TestClientFactory.java
index 212e56c..0eb1467 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/TestClientFactory.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/TestClientFactory.java
@@ -36,12 +36,7 @@ public final class TestClientFactory {
     public static final String RESOURCE_PATH = "conf/remote-objects.yaml";
 
     public static Cluster.Builder build() {
-        // if we let low resource environments have their way with getAvailableProcessors() workerPoolSize gets set
-        // to 1 and the ClusteredClient will have trouble initializing because initializeImplementation() does a
-        // join() to wait for ConnectionPool to initialize, but ConnectionPool also schedules tasks to join() in its
-        // constructor in the same executor. If there's only one thread we get a deadlock (or perhaps some odd case
-        // where multiple hosts schedule in a similar manner to exhaust whatever the size of the workerPoolSize is)
-        return Cluster.build("localhost").port(45940).workerPoolSize(4);
+        return Cluster.build("localhost").port(45940);
     }
 
     public static Cluster open() {