You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/02/03 16:36:55 UTC
[GitHub] flink pull request #3263: [FLINK-5699] [savepoints] Check target dir when ca...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3263
[FLINK-5699] [savepoints] Check target dir when cancelling with savepoint
When cancelling a job with a savepoint and no savepoint directory is configured, triggering the savepoint fails with an NPE. This is then returned to the user as the root cause.
Instead of simply forwarding the argument (which is possibly null), we check it for null and return a IllegalStateException with a meaningful message.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink 5699-cancel_with_savepoint_directory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3263
----
commit 5d06fd1c9b3a9ac1b404618b5bc843596e89e0ba
Author: Ufuk Celebi <uc...@apache.org>
Date: 2017-02-03T16:28:27Z
[FLINK-5699] [savepoints] Check target dir when cancelling with savepoint
Problem: when cancelling a job with a savepoint and no savepoint directory
is configured, triggering the savepoint fails with an NPE. This is then
returned to the user as the root cause.
Solution: Instead of simply forwarding the argument (which is possibly
null), we check it for null and return a IllegalStateException with
a meaningful message.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3263: [FLINK-5699] [savepoints] Check target dir when ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3263: [FLINK-5699] [savepoints] Check target dir when cancellin...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3263
Build failures are unrelated in change is self-contained. Merging this to `master` and `release-1.2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---