[GitHub] [sling-org-apache-sling-distribution-journal-kafka] tmaret commented on a change in pull request #4: SLING-8409 - Improve test coverage

[GitBox <gi...@apache.org>]

tmaret commented on a change in pull request #4: SLING-8409 - Improve test coverage
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka/pull/4#discussion_r282415048
 
 

 ##########
 File path: src/main/java/org/apache/sling/distribution/journal/kafka/KafkaClientProvider.java
 ##########
 @@ -112,7 +115,7 @@ public void close() {
     @Override
     public Closeable createPoller(String topicName, Reset reset, @Nullable String assign, HandlerAdapter<?>... adapters) {
         String consumerGroupId = UUID.randomUUID().toString();
-        KafkaConsumer<String, byte[]> consumer = new KafkaConsumer<>(consumerConfig(ByteArrayDeserializer.class, consumerGroupId, reset));
+        KafkaConsumer<String, byte[]> consumer = createConsumer(ByteArrayDeserializer.class, reset);
 
 Review comment:
   Due to this refactoring the `info` level log statement below is wrong (the `consumerGroupId` is not the one used in the message poller). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services