You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/18 08:52:18 UTC
[GitHub] [dubbo-go] gaoxinge opened a new pull request #763: code clean
gaoxinge opened a new pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
主要修改了`dubbo server`的`newSession`函数：
- 移除了重复的代码
- 增加了报错
**Special notes for your reviewer**:
- None.
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on a change in pull request #763: code clean
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on a change in pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763#discussion_r491260820
##########
File path: config/remote_config.go
##########
@@ -40,7 +40,7 @@ type RemoteConfig struct {
TimeoutStr string `default:"5s" yaml:"timeout" json:"timeout,omitempty"`
Username string `yaml:"username" json:"username,omitempty" property:"username"`
Password string `yaml:"password" json:"password,omitempty" property:"password"`
- Params map[string]string `yaml:"params" json:"address,omitempty"`
+ Params map[string]string `yaml:"params" json:"params,omitempty"`
Review comment:
https://github.com/apache/dubbo-go/blob/811f4f1a2dcc75b4294f62cb795da0f3f399be93/config/remote_config.go#L37-L44
This is another json tag `address` for `Address`. I think that tag `address` for `Params` is duplicated and wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #763: code clean
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763#discussion_r490908297
##########
File path: config/remote_config.go
##########
@@ -40,7 +40,7 @@ type RemoteConfig struct {
TimeoutStr string `default:"5s" yaml:"timeout" json:"timeout,omitempty"`
Username string `yaml:"username" json:"username,omitempty" property:"username"`
Password string `yaml:"password" json:"password,omitempty" property:"password"`
- Params map[string]string `yaml:"params" json:"address,omitempty"`
+ Params map[string]string `yaml:"params" json:"params,omitempty"`
Review comment:
pls do not change the json tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng merged pull request #763: Fmt: code clean
Posted by GitBox <gi...@apache.org>.
fangyincheng merged pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #763: code clean
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #763:
URL: https://github.com/apache/dubbo-go/pull/763#discussion_r491266675
##########
File path: config/remote_config.go
##########
@@ -40,7 +40,7 @@ type RemoteConfig struct {
TimeoutStr string `default:"5s" yaml:"timeout" json:"timeout,omitempty"`
Username string `yaml:"username" json:"username,omitempty" property:"username"`
Password string `yaml:"password" json:"password,omitempty" property:"password"`
- Params map[string]string `yaml:"params" json:"address,omitempty"`
+ Params map[string]string `yaml:"params" json:"params,omitempty"`
Review comment:
ok. u r right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org