You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2015/03/01 15:44:04 UTC

[jira] [Updated] (LUCENE-6317) Fix readStringStringMap api

     [ https://issues.apache.org/jira/browse/LUCENE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-6317:
--------------------------------
    Attachment: LUCENE-6317.patch

Here are my proposed new methods and simple tests. They also remove the leniency of null parameters at write.

If this is ok, I can work on fixing .si/.fis/.sis to use them.


> Fix readStringStringMap api
> ---------------------------
>
>                 Key: LUCENE-6317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6317
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6317.patch
>
>
> Currently this api is not very efficient, and always returns a mutable map.
> Can we change it to allow immutability? its sad we don't return Collections.emptyMap so its the same instance for all empty cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org