[GitHub] [beam] aromanenko-dev commented on a change in pull request #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s)

[GitBox <gi...@apache.org>]

aromanenko-dev commented on a change in pull request #11099: [BEAM-9420] Configurable timeout for blocking kafka API call(s)
URL: https://github.com/apache/beam/pull/11099#discussion_r397111316
 
 

 ##########
 File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
 ##########
 @@ -827,6 +832,19 @@ public void setValueDeserializer(String valueDeserializer) {
       return toBuilder().setOffsetConsumerConfig(offsetConsumerConfig).build();
     }
 
+    /**
+     * Sets a default timeout to use for API calls to Kafka which are possibly blocking. {@link
+     * KafkaIO.Read} will not wait indefinitely for such calls but cancels them and fail after given
+     * timeout.
+     *
+     * <p>Higher versions of kafka client library supports such API timeout, which is passed in
+     * consumer config as `default.api.timeout.ms`. If timeout is not explicitly set here, then
+     * {@link KafkaIO.Read} will look for `default.api.timeout.ms` parameter in consumer config.
+     */
+    public Read<K, V> withDefaultKafkaApiTimeout(Duration timeout) {
 
 Review comment:
   Instead of exposing it into user API as a separate call, can we just leverage `default.api.timeout.ms` config option if it's present? If it was not set by default (old version of Kafka client, for example) then we can ask user to set explicitly with `withConsumerConfigUpdates()`? And finally, it was not set in any case, just use default value as it was before. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services