You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/10/28 11:44:55 UTC
[PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
xuzifu666 opened a new pull request, #9935:
URL: https://github.com/apache/hudi/pull/9935
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success
### Impact
none
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
low
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1783798816
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8685f4f168a58d7bc049630b5ebec34af483446b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1784435868
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
}, {
"hash" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8685f4f168a58d7bc049630b5ebec34af483446b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541)
* 7bed8d22582f9262c6a2af0050ae1da71993b086 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9935:
URL: https://github.com/apache/hudi/pull/9935#discussion_r1375611945
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -304,7 +304,7 @@ public void deleteInstantFileIfExists(HoodieInstant instant) {
if (result) {
LOG.info("Removed instant " + instant);
} else {
- throw new HoodieIOException("Could not delete instant " + instant);
+ throw new HoodieIOException("Could not delete instant " + instant + " and path is " + commitFilePath);
Review Comment:
"Could not delete instant " + instant + " with path " + commitFilePath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1783789564
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8685f4f168a58d7bc049630b5ebec34af483446b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar merged PR #9935:
URL: https://github.com/apache/hudi/pull/9935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1783852032
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8685f4f168a58d7bc049630b5ebec34af483446b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9935:
URL: https://github.com/apache/hudi/pull/9935#discussion_r1375623918
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java:
##########
@@ -304,7 +304,7 @@ public void deleteInstantFileIfExists(HoodieInstant instant) {
if (result) {
LOG.info("Removed instant " + instant);
} else {
- throw new HoodieIOException("Could not delete instant " + instant);
+ throw new HoodieIOException("Could not delete instant " + instant + " and path is " + commitFilePath);
Review Comment:
changed @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1784519976
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
}, {
"hash" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20550",
"triggerID" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bed8d22582f9262c6a2af0050ae1da71993b086 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20550)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7000] Fix HoodieActiveTimeline::deleteInstantFileIfExists not show the file path when occur delete not success [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9935:
URL: https://github.com/apache/hudi/pull/9935#issuecomment-1784469306
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541",
"triggerID" : "8685f4f168a58d7bc049630b5ebec34af483446b",
"triggerType" : "PUSH"
}, {
"hash" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20550",
"triggerID" : "7bed8d22582f9262c6a2af0050ae1da71993b086",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8685f4f168a58d7bc049630b5ebec34af483446b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20541)
* 7bed8d22582f9262c6a2af0050ae1da71993b086 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20550)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org