You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/05/15 18:35:12 UTC
Review Request 59281: Integrate BlueprintService and subresources with
swagger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-21026
https://issues.apache.org/jira/browse/AMBARI-21026
Repository: ambari
Description
-------
Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1
ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4
ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION
Diff: https://reviews.apache.org/r/59281/diff/1/
Testing
-------
All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443.
Thanks,
Balázs Bence Sári
Re: Review Request 59281: Integrate BlueprintService and subresources
with swagger
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/#review175006
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 15, 2017, 6:35 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59281/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 6:35 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21026
> https://issues.apache.org/jira/browse/AMBARI-21026
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4
> ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59281/diff/1/
>
>
> Testing
> -------
>
> All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 59281: Integrate BlueprintService and subresources
with swagger
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/
-----------------------------------------------------------
(Updated May 18, 2017, 9:27 a.m.)
Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
Changes
-------
Review comments fixed
Bugs: AMBARI-21026
https://issues.apache.org/jira/browse/AMBARI-21026
Repository: ambari
Description
-------
Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 2808911
ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4
ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION
Diff: https://reviews.apache.org/r/59281/diff/2/
Changes: https://reviews.apache.org/r/59281/diff/1-2/
Testing
-------
All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443.
Thanks,
Balázs Bence Sári
Re: Review Request 59281: Integrate BlueprintService and subresources
with swagger
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/#review175212
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java
Line 55 (original), 68 (patched)
<https://reviews.apache.org/r/59281/#comment248633>
Is `@Produces` intentionally removed?
ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java
Line 71 (original), 103 (patched)
<https://reviews.apache.org/r/59281/#comment248634>
Is `@Produces` intentionally removed?
- Attila Doroszlai
On May 15, 2017, 8:35 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59281/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 8:35 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-21026
> https://issues.apache.org/jira/browse/AMBARI-21026
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not elaborated.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java 0b2afd1
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java 8159ea4
> ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/59281/diff/1/
>
>
> Testing
> -------
>
> All unit tests for ambari-server pass, except ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to AMBARI-20443.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>