[jira] [Commented] (FLINK-30409) Support reopening closed metric groups

["Mason Chen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-30409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646906#comment-17646906 ] 

Mason Chen commented on FLINK-30409:
------------------------------------

cc: [~chesnay] what do you think about this? 

> Support reopening closed metric groups
> --------------------------------------
>
>                 Key: FLINK-30409
>                 URL: https://issues.apache.org/jira/browse/FLINK-30409
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Metrics
>    Affects Versions: 1.17.0
>            Reporter: Mason Chen
>            Priority: Major
>
> Currently, metricGroup.close() will unregister metrics and the underlying metric groups. If the metricGroup is created again via addGroup(), it will silently fail to create metrics since the metric group is in a closed state.
> We need to close metric groups and reopen them because some of the metrics may reference old objects that are no longer relevant/stale and we need to re-create the metric/metric group to point to the new references. For example, we may close `KafkaSourceReader` to remove a topic partition from assignment and then recreate `KafkaSourceReader` with a different set of topic partitions. The metrics should also reflect that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)