You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/11 11:10:21 UTC

[GitHub] [cloudstack] borisstoyanov opened a new issue #4052: Remove 'make redundant' option from the restart network pop-up.

borisstoyanov opened a new issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052


   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and master branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   UI and Primate
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on master branch.
   -->
   
   ~~~
   4.14
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   This should be defined at an offering level, simply having the option to turn a network into redundant shouldn't be available on restart as it's confusing people 
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   
   <!-- Paste example playbooks or commands between quotes below -->
   ~~~
   Restart a network and observe the option
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ![Screenshot 2020-04-30 at 14 41 05](https://user-images.githubusercontent.com/13551960/80718872-5f677580-8b03-11ea-8257-268fe2d72fa9.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] andrijapanicsb commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-624044266


   @borisstoyanov did you report this to the Primate project (raised bug there?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725930686


   @borisstoyanov  what you said is an option to change a network to redundant.
   
   makeredundant is an optional parameter of restartnetwork. it would be better to support it on Primate UI.
   
   ```
   (local) mgt01 > restart network
   cleanup=        filter=         id=             makeredundant=
   ```
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725915493


   @weizhouapache while it is working good in majority of cases, this is something that should be set on a service offering level, it's simply not in the right place. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725932523


   yes @weizhouapache, what I mean is not just the UI but this API shouldn't be there at all. Cloudstack uses offering model to set limits on the resources it gives to users. So if a user wants to have a redundant VR he should have such offering, simply changing that with a VR restart is in conflict with this model. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725933212


   ![Screenshot 2020-11-12 at 10 44 55](https://user-images.githubusercontent.com/13551960/98916674-1cd01e00-24d4-11eb-8a1d-c1b3471504ec.png)
   As you see this seems to be available to users as well which is not really great. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725944540


   > ![Screenshot 2020-11-12 at 10 44 55](https://user-images.githubusercontent.com/13551960/98916674-1cd01e00-24d4-11eb-8a1d-c1b3471504ec.png)
   > As you see this seems to be available to users as well which is not really great.
   
   yeah. however we have used that feature for years.
   so if you want to change it, could you add a global setting to enable/disable the feature to keep backwards compatibility ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-655309492


   @borisstoyanov this is fixed in Primate
   ![Screenshot from 2020-07-08 11-42-01](https://user-images.githubusercontent.com/95203/86883710-11c54580-c110-11ea-9fb4-2d0cffc84189.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725361310


   with latests master installed from nightly I can still see this
   ![Screenshot 2020-11-11 at 13 09 39](https://user-images.githubusercontent.com/13551960/98804728-36fbf480-241f-11eb-9230-738f836ff97e.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-791909112


   This was a recently added UI feature, available via API though. We can hide it in UI as users from 4.9/4.11/4.13 can cause additional/unanticipated VR resource consumption for IaaS hosting/providers.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725948853


   We've discussed previously that we'll simply remove it from UI for now as first step, but it's still going to be there in cmk. Does this work for you @weizhouapache ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725361679


   this is cloudstack-primate-1.0.0-20201110.x86_64.rpm


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-726565693


   it's just this issue, not sure if there's anything in the primate repo. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-624045675


   No, I've marked the component as UI and Primate, it needs to be tested against both when picket up. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-726156999


   @borisstoyanov thanks for your explanation. could you give me a link about the discussion ? thanks !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #4052: Remove 'make redundant' option from the restart network pop-up.

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4052:
URL: https://github.com/apache/cloudstack/issues/4052#issuecomment-725367402


   @rhtyd @borisstoyanov 
   I think this works fine in old UI, why remove it from Primate ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org