You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/05 15:39:10 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #19140: [cleanup][txn] Use MLTransactionMetadataStore in integration tests
nicoloboschi opened a new pull request, #19140:
URL: https://github.com/apache/pulsar/pull/19140
### Motivation
Transaction's integration tests use the in memory implementation for the txn metadata store.
Since they're very important test to ensure stability of the transactions feature, it's better to use the default store which is actually designed to run in production environments.
### Modifications
* Do not set `InMemTransactionMetadataStoreProvider` in the integration tests setup
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #19140: [cleanup][txn] Use MLTransactionMetadataStore in integration tests
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #19140:
URL: https://github.com/apache/pulsar/pull/19140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #19140: [cleanup][txn] Use MLTransactionMetadataStore in integration tests
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #19140:
URL: https://github.com/apache/pulsar/pull/19140#issuecomment-1373067331
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19140: [cleanup][txn] Use MLTransactionMetadataStore in integration tests
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19140:
URL: https://github.com/apache/pulsar/pull/19140#issuecomment-1373077074
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19140](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8e48e1) into [master](https://codecov.io/gh/apache/pulsar/commit/4b8f447d88d3523c36903c5d984541d6c5571978?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b8f447) will **decrease** coverage by `9.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19140 +/- ##
============================================
- Coverage 47.00% 37.26% -9.74%
+ Complexity 10639 1990 -8649
============================================
Files 713 209 -504
Lines 69672 14452 -55220
Branches 7482 1577 -5905
============================================
- Hits 32746 5386 -27360
+ Misses 33212 8480 -24732
+ Partials 3714 586 -3128
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `37.26% <ø> (-9.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/pulsar/broker/admin/impl/BrokersBase.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL0Jyb2tlcnNCYXNlLmphdmE=) | | |
| [...g/apache/pulsar/PulsarClusterMetadataTeardown.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL1B1bHNhckNsdXN0ZXJNZXRhZGF0YVRlYXJkb3duLmphdmE=) | | |
| [...ad/jcloud/provider/TieredStorageConfiguration.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkLXN0b3JhZ2UvamNsb3VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ib29ra2VlcGVyL21sZWRnZXIvb2ZmbG9hZC9qY2xvdWQvcHJvdmlkZXIvVGllcmVkU3RvcmFnZUNvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...rcegroup/ResourceGroupNamespaceConfigListener.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXNvdXJjZWdyb3VwL1Jlc291cmNlR3JvdXBOYW1lc3BhY2VDb25maWdMaXN0ZW5lci5qYXZh) | | |
| [...r/offload/jcloud/impl/OffloadIndexBlockV2Impl.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGllcmVkLXN0b3JhZ2UvamNsb3VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ib29ra2VlcGVyL21sZWRnZXIvb2ZmbG9hZC9qY2xvdWQvaW1wbC9PZmZsb2FkSW5kZXhCbG9ja1YySW1wbC5qYXZh) | | |
| [.../java/org/apache/pulsar/broker/web/WebService.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci93ZWIvV2ViU2VydmljZS5qYXZh) | | |
| [...kkeeper/mledger/impl/LedgerOffloaderStatsImpl.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL0xlZGdlck9mZmxvYWRlclN0YXRzSW1wbC5qYXZh) | | |
| [...ar/broker/service/persistent/ShadowReplicator.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvU2hhZG93UmVwbGljYXRvci5qYXZh) | | |
| [...r/delayed/bucket/BucketDelayedDeliveryTracker.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9kZWxheWVkL2J1Y2tldC9CdWNrZXREZWxheWVkRGVsaXZlcnlUcmFja2VyLmphdmE=) | | |
| [...sistent/PersistentDispatcherMultipleConsumers.java](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudERpc3BhdGNoZXJNdWx0aXBsZUNvbnN1bWVycy5qYXZh) | | |
| ... and [495 more](https://codecov.io/gh/apache/pulsar/pull/19140?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org