[jira] Commented: (MRELEASE-383) svn inconsistent line ending style

["Brett Porter (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MRELEASE-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=209607#action_209607 ] 

Brett Porter commented on MRELEASE-383:
---------------------------------------

I believe I've fixed the test. Since the code always goes to to the platform's LS, the test relies on the input files being in the platform's LS. However, that wouldn't effectively test this problem on Linux machines, and would cause the build to fail on Linux if you download a source distro with CRLF input files.

I changed it so the input files are always CRLF just for this test, and that the code runs with CRLF as the LS instead of the platform one, achieving consistent results.

> svn inconsistent line ending style
> ----------------------------------
>
>                 Key: MRELEASE-383
>                 URL: http://jira.codehaus.org/browse/MRELEASE-383
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>            Reporter: Barrie Treloar
>            Assignee: nicolas de loof
>             Fix For: 2.0
>
>
> The problem occurs in the CDATA section of the maven-eclipse-plugin -
> when setting the contents of the .checkstyle file.
> {code:xml}
> pom.xml
> ...
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-eclipse-plugin</artifactId>
>          <configuration>
>            <downloadSources>true</downloadSources>
>            <additionalBuildcommands>
>              <buildcommand>com.atlassw.tools.eclipse.checkstyle.CheckstyleBuilder</buildcommand>
>            </additionalBuildcommands>
>            <additionalProjectnatures>
>              <projectnature>com.atlassw.tools.eclipse.checkstyle.CheckstyleNature</projectnature>
>            </additionalProjectnatures>
>            <additionalConfig>
>              <file>
>                <name>.checkstyle</name>
>                <content>
>                  <![CDATA[<?xml version="1.0" encoding="UTF-8"?>
> <fileset-config file-format-version="1.2.0" simple-config="true">
>    <fileset name="all" enabled="true" check-config-name="QifCon" local="false">
>        <file-match-pattern match-pattern="." include-pattern="true" />
>    </fileset>
> </fileset-config>
> ]]>
>                </content>
>              </file>
>            </additionalConfig>
>          </configuration>
>        </plugin>
>      </plugins>
> {code}
> When this file is transformed the CDATA section has LF only.
> On windows it should have CR LF.
> I suspect because it uses \n instead of System.getProperty( line.separator );

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira