[GitHub] [doris] morningman commented on a diff in pull request #15321: [profile](scanner) add per scanner running time profile

[GitBox <gi...@apache.org>]

morningman commented on code in PR #15321:
URL: https://github.com/apache/doris/pull/15321#discussion_r1056760200


##########
be/src/vec/exec/scan/scanner_context.cpp:
##########
@@ -174,11 +176,30 @@ bool ScannerContext::set_status_on_error(const Status& status) {
 
 Status ScannerContext::_close_and_clear_scanners() {
     std::unique_lock<std::mutex> l(_scanners_lock);
+    std::stringstream scanner_statistics;

Review Comment:
   This is a hot path, better use `fmt`.
   And print it only when `enable_profile` is true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org