You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/04/10 19:21:08 UTC
qpid-dispatch git commit: DISPATCH-739: Remove un-necessary valgrind
flags in run.py.in
Repository: qpid-dispatch
Updated Branches:
refs/heads/master b7b9d560f -> cf3a26b7c
DISPATCH-739: Remove un-necessary valgrind flags in run.py.in
Defaults are fine, removing them means the developer can set them in ~/.valgrindrc.
In particular --num-callers shouldn't be too high by default (slower) but it is
useful to increase it in .valgrindrc while investigating valgrind errors.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/cf3a26b7
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/cf3a26b7
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/cf3a26b7
Branch: refs/heads/master
Commit: cf3a26b7c3b0e66bb5c778e73818a120a173277d
Parents: b7b9d56
Author: Alan Conway <ac...@redhat.com>
Authored: Thu Apr 6 18:01:26 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Mon Apr 10 15:20:19 2017 -0400
----------------------------------------------------------------------
run.py.in | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/cf3a26b7/run.py.in
----------------------------------------------------------------------
diff --git a/run.py.in b/run.py.in
index 266a703..cfafde8 100755
--- a/run.py.in
+++ b/run.py.in
@@ -115,15 +115,12 @@ def is_binary_exe(program):
VALGRIND_ERROR = 42 # magic number indicating valgrind found errors
def with_valgrind(args, outfile=None):
if use_valgrind() and is_binary_exe(find_exe(args[0])):
- opts = ['--trace-children=yes',
- '--leak-check=full',
+ opts = ['--leak-check=full',
# Python generates a ton of "possibly lost" and "still in use"
# false alarms, restrict to "definite" leaks.
# Ideally we should have more specific python exclusions.
'--show-leak-kinds=definite',
'--errors-for-leak-kinds=definite',
- '--demangle=yes',
- '--num-callers=12',
'--error-exitcode=%d' % VALGRIND_ERROR,
'--quiet']
opts.append('--tool=%s' % os.environ.get('VALGRIND_TOOL', 'memcheck'))
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org