[GitHub] [helix] zhangmeng916 commented on a change in pull request #1560: fix test Helix-rest testAddConfigFields

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #1560:
URL: https://github.com/apache/helix/pull/1560#discussion_r533086778



##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -224,7 +224,7 @@ public void testGetClusterTopologyAndFaultZoneMap() throws IOException {
   @Test(dependsOnMethods = "testGetClusterTopologyAndFaultZoneMap")
   public void testAddConfigFields() throws IOException {
     System.out.println("Start test :" + TestHelper.getTestMethodName());
-    String cluster = _clusters.iterator().next();
+    String cluster = "TestCluster_1";

Review comment:
       This fix could work, but it is not very intuitive for writing future tests. People may easily overlook the guideline. Do you think it's possible to reset the cluster back to normal after waged related tests? If it's not feasible, we may want to add more description for this guideline or not to name it simply as 0, 1, 2.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org