You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/26 14:24:42 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #6180: [AIRFLOW-5549] Exteded BQ GetDataOperator to handle query params

feluelle commented on a change in pull request #6180: [AIRFLOW-5549] Exteded BQ GetDataOperator to handle query params
URL: https://github.com/apache/airflow/pull/6180#discussion_r328638193
 
 

 ##########
 File path: airflow/gcp/operators/bigquery.py
 ##########
 @@ -259,6 +267,9 @@ class BigQueryGetDataOperator(BaseOperator):
     :type delegate_to: str
     :param location: The location used for the operation.
     :type location: str
+
+    :rtype: dict
+        Map containing the requested rows + metadata.
 
 Review comment:
   That's the return value of the `execute` function, isn't it? `:rtype: dict` will show up in an IDE that `__init__` is returning a dict which is wrong. You also find the return value of `__init__` in line 290 (`-> None:`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services