You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Bruno Cadonna <br...@confluent.io> on 2020/08/21 15:06:17 UTC
[DISCUSS] KIP-662: Throw Exception when Source Topics of a Streams
App are Deleted
Hi,
I would like to propose the following KIP:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted
Best,
Bruno
Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a
Streams App are Deleted
Posted by Bruno Cadonna <br...@confluent.io>.
Hi Guozhang,
Thank you for pointing this out. I added the package to the KIP.
Best,
Bruno
On 24.08.20 20:55, Guozhang Wang wrote:
> Hello Bruno,
>
> Thanks for the KIP, it sounds good to me as well. Just a minor comment: we
> would include which package the new "MissingSourceTopicException" class
> belongs to.
>
>
>
> Guozhang
>
>
> On Fri, Aug 21, 2020 at 11:53 AM John Roesler <vv...@apache.org> wrote:
>
>> Thanks for the KIP, Bruno!
>>
>> Your proposal sounds good to me.
>>
>> -John
>>
>> On Fri, 2020-08-21 at 11:18 -0700, Sophie Blee-Goldman
>> wrote:
>>> Thanks for the KIP! I'm totally in favor of this approach and to be
>> honest,
>>> have
>>> always wondered why we just silently shut down instead of throwing an
>>> exception.
>>> This has definitely been a source of confusion for users in my personal
>>> experience.
>>>
>>> I was originally hesitant to extend StreamsException since I always
>> thought
>>> that anything
>>> extending from KafkaException was supposed to "indicate Streams internal
>>> errors"
>>> -- a phrase I'm quoting from Streams logs directly -- but I now see that
>>> we're actually
>>> somewhat inconsistent here. Perhaps "Streams internal errors" does not in
>>> fact mean
>>> internal to Streams itself but just any error that occurs during Stream
>>> processing?
>>>
>>> Anyways, I'm looking forward to cleaning up the exception hierarchy so we
>>> get a clear
>>> division of user vs "internal" error, but within the current framework
>> this
>>> SGTM
>>>
>>> On Fri, Aug 21, 2020 at 8:06 AM Bruno Cadonna <br...@confluent.io>
>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I would like to propose the following KIP:
>>>>
>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted
>>>>
>>>> Best,
>>>> Bruno
>>>>
>>
>>
>
Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a
Streams App are Deleted
Posted by Guozhang Wang <wa...@gmail.com>.
Hello Bruno,
Thanks for the KIP, it sounds good to me as well. Just a minor comment: we
would include which package the new "MissingSourceTopicException" class
belongs to.
Guozhang
On Fri, Aug 21, 2020 at 11:53 AM John Roesler <vv...@apache.org> wrote:
> Thanks for the KIP, Bruno!
>
> Your proposal sounds good to me.
>
> -John
>
> On Fri, 2020-08-21 at 11:18 -0700, Sophie Blee-Goldman
> wrote:
> > Thanks for the KIP! I'm totally in favor of this approach and to be
> honest,
> > have
> > always wondered why we just silently shut down instead of throwing an
> > exception.
> > This has definitely been a source of confusion for users in my personal
> > experience.
> >
> > I was originally hesitant to extend StreamsException since I always
> thought
> > that anything
> > extending from KafkaException was supposed to "indicate Streams internal
> > errors"
> > -- a phrase I'm quoting from Streams logs directly -- but I now see that
> > we're actually
> > somewhat inconsistent here. Perhaps "Streams internal errors" does not in
> > fact mean
> > internal to Streams itself but just any error that occurs during Stream
> > processing?
> >
> > Anyways, I'm looking forward to cleaning up the exception hierarchy so we
> > get a clear
> > division of user vs "internal" error, but within the current framework
> this
> > SGTM
> >
> > On Fri, Aug 21, 2020 at 8:06 AM Bruno Cadonna <br...@confluent.io>
> wrote:
> >
> > > Hi,
> > >
> > > I would like to propose the following KIP:
> > >
> > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted
> > >
> > > Best,
> > > Bruno
> > >
>
>
--
-- Guozhang
Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a
Streams App are Deleted
Posted by John Roesler <vv...@apache.org>.
Thanks for the KIP, Bruno!
Your proposal sounds good to me.
-John
On Fri, 2020-08-21 at 11:18 -0700, Sophie Blee-Goldman
wrote:
> Thanks for the KIP! I'm totally in favor of this approach and to be honest,
> have
> always wondered why we just silently shut down instead of throwing an
> exception.
> This has definitely been a source of confusion for users in my personal
> experience.
>
> I was originally hesitant to extend StreamsException since I always thought
> that anything
> extending from KafkaException was supposed to "indicate Streams internal
> errors"
> -- a phrase I'm quoting from Streams logs directly -- but I now see that
> we're actually
> somewhat inconsistent here. Perhaps "Streams internal errors" does not in
> fact mean
> internal to Streams itself but just any error that occurs during Stream
> processing?
>
> Anyways, I'm looking forward to cleaning up the exception hierarchy so we
> get a clear
> division of user vs "internal" error, but within the current framework this
> SGTM
>
> On Fri, Aug 21, 2020 at 8:06 AM Bruno Cadonna <br...@confluent.io> wrote:
>
> > Hi,
> >
> > I would like to propose the following KIP:
> >
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted
> >
> > Best,
> > Bruno
> >
Re: [DISCUSS] KIP-662: Throw Exception when Source Topics of a
Streams App are Deleted
Posted by Sophie Blee-Goldman <so...@confluent.io>.
Thanks for the KIP! I'm totally in favor of this approach and to be honest,
have
always wondered why we just silently shut down instead of throwing an
exception.
This has definitely been a source of confusion for users in my personal
experience.
I was originally hesitant to extend StreamsException since I always thought
that anything
extending from KafkaException was supposed to "indicate Streams internal
errors"
-- a phrase I'm quoting from Streams logs directly -- but I now see that
we're actually
somewhat inconsistent here. Perhaps "Streams internal errors" does not in
fact mean
internal to Streams itself but just any error that occurs during Stream
processing?
Anyways, I'm looking forward to cleaning up the exception hierarchy so we
get a clear
division of user vs "internal" error, but within the current framework this
SGTM
On Fri, Aug 21, 2020 at 8:06 AM Bruno Cadonna <br...@confluent.io> wrote:
> Hi,
>
> I would like to propose the following KIP:
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-662%3A+Throw+Exception+when+Source+Topics+of+a+Streams+App+are+Deleted
>
> Best,
> Bruno
>