[jira] [Commented] (MDEP-941) Deprecate dependency:sources in favor of dependency:resolve-sources

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MDEP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880732#comment-17880732 ] 

ASF GitHub Bot commented on MDEP-941:
-------------------------------------

jglick commented on code in PR #411:
URL: https://github.com/apache/maven-dependency-plugin/pull/411#discussion_r1752355235


##########
src/main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.resolvers;
+
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.ResolutionScope;
+
+/**
+ * Goal that resolves the project source dependencies from the repository.
+ *
+ * @author <a href="mailto:brianf@apache.org">Brian Fox</a>
+ * @since 2.0-alpha2
+ * @deprecated in favor of {@code resolve-sources} goal and will be removed in a future version

Review Comment:
   This message fails to explain that the goals are functionally identical, differing only in name. I looked through the plugin site and FAQ trying to find some explanation of why I should switch and what parameters I would need to change, finally coming across this PR via code archaeology.





> Deprecate dependency:sources in favor of dependency:resolve-sources
> -------------------------------------------------------------------
>
>                 Key: MDEP-941
>                 URL: https://issues.apache.org/jira/browse/MDEP-941
>             Project: Maven Dependency Plugin
>          Issue Type: Task
>          Components: sources
>    Affects Versions: 3.6.1
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 3.7.0
>
>
> Unfortunately, the goal name does not really depict what the goal is doing, it fact it causes confusion as in MDEP-895. The name should clearly say that it *resolves* sources and does not collect (semantics is imporant). The new goal {{resolve-sources}} is functionally equivalent, but is just more expressive.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)