You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jordanhaven <gi...@git.apache.org> on 2017/02/09 21:45:35 UTC
[GitHub] cordova-plugins pull request #28: CB-12443 CB-10959 (ios) include path and f...
GitHub user jordanhaven opened a pull request:
https://github.com/apache/cordova-plugins/pull/28
CB-12443 CB-10959 (ios) include path and fragment when updating startPage
When setting the startPage, ensure that paths and fragments are included
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jordanhaven/cordova-plugins master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugins/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 28e0ef194e08d5602cfbbf30cd6420d51526d897
Author: Jordan Haven <jh...@gmail.com>
Date: 2017-02-09T21:27:22Z
CB-12443 CB-10959 (ios) include path and fragment when updating startPage
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugins issue #28: CB-12443 CB-10959 (ios) include path and fragment...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugins/pull/28
FYI, the `local-webserver` code has been moved to a [branch](https://github.com/apache/cordova-plugins/tree/local-webserver), see the README in the root of this repo.
Don't worry about having to change this PR to rebase off the branch (unless you want to), just address the review comments, I can integrate it into the branch later manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugins pull request #28: CB-12443 CB-10959 (ios) include path and f...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/28#discussion_r102574949
--- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
@@ -52,6 +53,12 @@ - (void) pluginInitialize {
if (startPageUrl != nil) {
if ([[startPageUrl scheme] isEqualToString:@"http"] && [[startPageUrl host] isEqualToString:@"localhost"]) {
port = [[startPageUrl port] unsignedIntegerValue];
+ if ([startPageUrl path].length > 1) {
+ indexPage = [[startPageUrl path] substringFromIndex:1];
+ }
+ if ([startPageUrl fragment].length > 1) {
--- End diff --
Similarly here. Fragments that are 1 char in length will not be considered as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugins pull request #28: CB-12443 CB-10959 (ios) include path and f...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/28#discussion_r102574864
--- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
@@ -52,6 +53,12 @@ - (void) pluginInitialize {
if (startPageUrl != nil) {
if ([[startPageUrl scheme] isEqualToString:@"http"] && [[startPageUrl host] isEqualToString:@"localhost"]) {
port = [[startPageUrl port] unsignedIntegerValue];
+ if ([startPageUrl path].length > 1) {
--- End diff --
Why > 1? Paths that are 1 char in length won't get used here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org