You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/06/10 20:42:58 UTC
Review Request 22429: Add getConfigGroupSummary API endpoint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
Review request for Aurora, Deprecated Use kevints and Maxim Khutornenko.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 425
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line425>
> >
> > s/public/private?
Done.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 436
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line436>
> >
> > Better use:
> >
> > IJobKey jobKey = JobKeys.assertValid(IJobKey.build(mutableJobKey));
Done.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 440
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line440>
> >
> > Any reason to do a deep copy of it here?
Fixed.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 442
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line442>
> >
> > This could be merged with activeTasks to eliminate naming confusion.
I think it's more readable this way.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 443
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line443>
> >
> > s/byInstance/taskByInstance?
Done.
> On June 12, 2014, 1:22 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 452
> > <https://reviews.apache.org/r/22429/diff/1/?file=606598#file606598line452>
> >
> > Merge it with okResponse(...)?
I also think it's more readable this way. Also consistent with other functions.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review45449
-----------------------------------------------------------
On June 12, 2014, 5:38 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 5:38 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review45449
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80313>
s/public/private?
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80320>
Better use:
IJobKey jobKey = JobKeys.assertValid(IJobKey.build(mutableJobKey));
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80314>
This used only in one place. Consider inlining it.
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80315>
Any reason to do a deep copy of it here?
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80316>
This could be merged with activeTasks to eliminate naming confusion.
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80318>
s/byInstance/taskByInstance?
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80319>
Merge it with okResponse(...)?
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
<https://reviews.apache.org/r/22429/#comment80317>
How about a test returning empty result in case job key has no match?
- Maxim Khutornenko
On June 10, 2014, 6:44 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 6:44 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review45961
-----------------------------------------------------------
Ping.
- David McLaughlin
On June 12, 2014, 6:10 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 6:10 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > Can you verify that ./gradlew FlagSchemaChanges passes?
Done (I expect I'll need to do this again after a rebase).
> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 429
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line429>
> >
> > Drop @Nullable
Done.
> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 430
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line430>
> >
> > favor immutability: ImmutableSet.copyOf(input.getValue())
Done.
> On June 19, 2014, 6:14 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 453
> > <https://reviews.apache.org/r/22429/diff/3/?file=608216#file608216line453>
> >
> > ImmutableSet.copyOf(groups)
Done.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46207
-----------------------------------------------------------
On June 19, 2014, 6:34 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 6:34 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434
> src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b
> src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a
> src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259
> src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f
> src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46207
-----------------------------------------------------------
Can you verify that ./gradlew FlagSchemaChanges passes?
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment81499>
Drop @Nullable
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment81500>
favor immutability: ImmutableSet.copyOf(input.getValue())
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment81501>
ImmutableSet.copyOf(groups)
- Kevin Sweeney
On June 12, 2014, 11:10 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 11:10 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46218
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 19, 2014, 11:34 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 11:34 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434
> src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b
> src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a
> src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259
> src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f
> src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 23, 2014, 10:43 p.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2
src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c
src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5
Diff: https://reviews.apache.org/r/22429/diff/
Testing (updated)
-------
./gradlew build
./gradlew FlagSchemaChanges
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 23, 2014, 10:36 p.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
Review feedback + rebase.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2
src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c
src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On June 23, 2014, 10:21 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 436
> > <https://reviews.apache.org/r/22429/diff/4/?file=613082#file613082line436>
> >
> > redundant with the line below
Removed.
> On June 23, 2014, 10:21 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 239
> > <https://reviews.apache.org/r/22429/diff/4/?file=613083#file613083line239>
> >
> > remove extra newline
Done.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46464
-----------------------------------------------------------
On June 23, 2014, 10:36 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 10:36 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7cc435f49009d06c50f92f89bfaa7204220e73b2
> src/main/thrift/org/apache/aurora/gen/api.thrift 4a468d74371094b02203b02452338d974e8cd930
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 3807c1253469ca3250c1e0137fcf848afe79d06f
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 9991e3cb72030c1f305da8877f8cc24a363ccb7c
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 a201d3cf044c146e8c317684f06e81a1b10b5ef5
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review46464
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment81853>
redundant with the line below
src/main/thrift/org/apache/aurora/gen/api.thrift
<https://reviews.apache.org/r/22429/#comment81852>
remove extra newline
- Bill Farner
On June 19, 2014, 7:57 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 7:57 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
> src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434
> src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b
> src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a
> src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259
> src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f
> src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 19, 2014, 7:57 p.m.)
Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.
Changes
-------
+Bill in case he has some comments.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434
src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b
src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a
src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259
src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f
src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 19, 2014, 6:34 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Review feedback.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
src/test/resources/org/apache/aurora/gen/api.thrift.md5 5bd9e6b3246aa13d21d1d0d0e140dff61b707434
src/test/resources/org/apache/aurora/gen/internal_rpc.thrift.md5 452c912cf62c4b4ed665cee3aabaf4bb64e8108b
src/test/resources/org/apache/aurora/gen/storage.thrift.md5 9b948834700288a681350b75725dacb2e4d5630a
src/test/resources/org/apache/aurora/gen/storage_local.thrift.md5 8b9cd2987786e980a6d5ca2e176c40d7f2c2f259
src/test/resources/org/apache/aurora/gen/test.thrift.md5 ca13f91cc54f9390f2c6401c445f1f7c6fc8e97f
src/test/resources/org/apache/thermos/thermos_internal.thrift.md5 c14dd1694a9f7e62da468f1a99abdcfc30dcb151
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 12, 2014, 6:10 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Review feedback.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/#review45514
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/22429/#comment80372>
s/taskByInstance/tasksByInstance
- Maxim Khutornenko
On June 12, 2014, 5:38 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22429/
> -----------------------------------------------------------
>
> (Updated June 12, 2014, 5:38 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
>
>
> Bugs: AURORA-519
> https://issues.apache.org/jira/browse/AURORA-519
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
> src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
> src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
>
> Diff: https://reviews.apache.org/r/22429/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 12, 2014, 5:38 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Review feedback.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin
Re: Review Request 22429: Add getConfigGroupSummary API endpoint
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22429/
-----------------------------------------------------------
(Updated June 10, 2014, 6:44 p.m.)
Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
Changes
-------
Fixing people line.
Bugs: AURORA-519
https://issues.apache.org/jira/browse/AURORA-519
Repository: aurora
Description
-------
Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> Set<InstanceId> struct for active tasks. This will let us paginate active tasks, or drop TaskConfig from the getTasksStatus response in the future.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5
src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27
src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf
Diff: https://reviews.apache.org/r/22429/diff/
Testing
-------
./gradlew build
Thanks,
David McLaughlin