You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/21 23:49:14 UTC
[GitHub] [cordova-plugin-camera] hajunho opened a new pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
hajunho opened a new pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715
…ayImage.png"
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference. For complete details, please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Nothing.
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
Another Cordova Plug-in uses a Cordova camera also. Overlay view is the primary API of the iOS platform. I think the overlay view function is inserted into the Cordova primary function to follow the trend of native Apps.
<!-- If it fixes an open issue, please link to the issue here. -->
None.
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
I have several projects used by over 1000+ users of the company titled Daelim. I've tested with this plugin and tested the hello-world program. As you can see from the codes, It is just for the iOS user to overlay view. I think it starts at the codes to guide. Will uses very usefully later on. I think I can update & test every month for this.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] IllusionVK commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
IllusionVK commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1070614891
Hi @hajunho, so could you share the link to help some other people ?
And could you help us to understand what cameraoverlayview is used for, and is the link that I included the correct one ?(https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] hajunho commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
hajunho commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1065919544
Hello,
I think this function is not needed to this point.
Please drop my codes. Actually I found that the overlayview project for
camera on github.
Thank you
On Sat, Mar 12, 2022 at 23:16 Charlie Blundell ***@***.***>
wrote:
> Hey @hajunho <https://github.com/hajunho>! I have read all the comments
> on this, but i'm still not clear on what it does. Do your changes allow for
> the use of this?
> https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview
>
> And what exactly is that used for? when I looked it seems it can allow
> custom buttons ? or maybe overlay on preview ? (see some examples below)
>
> -
>
> Example 1: User is trying to show different buttons instead of normal
> iOS buttons:
>
> https://stackoverflow.com/questions/12734407/uiimagepickercontroller-cameraoverlayview-not-working-with-ipho
> -
>
> Example 2: user is trying to show a shape on the screen to help the
> user take a photo in the right location:
> jamesmontemagno/MediaPlugin#377
> <https://github.com/jamesmontemagno/MediaPlugin/issues/377>
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1065891043>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAGNE35BEULFIJCJHRAQRCTU7SRNFANCNFSM4ZSCXKSQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] timbru31 commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-803689683
Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] IllusionVK commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
IllusionVK commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1065891043
Hey @hajunho! I have read all the comments on this, but i'm still not clear on what it does. Do your changes allow for the use of this? https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview
And what exactly is that used for? when I looked it seems it can allow custom buttons ? or maybe overlay on preview ? (see some examples below)
- Example 1: User is trying to show different buttons instead of normal iOS buttons:
https://stackoverflow.com/questions/12734407/uiimagepickercontroller-cameraoverlayview-not-working-with-ipho
- Example 2: user is trying to show a shape on the screen to help the user take a photo in the right location:
https://github.com/jamesmontemagno/MediaPlugin/issues/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] hajunho commented on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
hajunho commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-804479753
> Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasible)
Thank you for reviewing. I didn't touch the established codes. It's just an indirection layer. As you already know, the overlay view can be used for the additional view to putting the picture after the function "taking the picture". We use this for the watermark for that(I had adjusted Alpha value 0.38). Platform-specific codes are not applicable, I know. but I agree with your opinion to add this function to Android also. These codes have to be changed after using the additional function by the native developer. What I didn't decide things is what options have to be inserted. i.e Alpha value, images, location, size, watermark or location, or timestamp options. Those are very big considering but I or somebody have to do I think. These are base codes for that and no errors(No called basically)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] IllusionVK edited a comment on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
IllusionVK edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1065891043
Hey @hajunho! I have read all the comments on this, but i'm still not clear on what it does. Do your changes allow for the use of this? https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview
And what exactly is that used for? when I looked it seems it can allow custom buttons ? or maybe overlay on preview ? (see some examples below)
- Example 1: User is trying to show different buttons instead of normal iOS buttons:
https://stackoverflow.com/questions/12734407/uiimagepickercontroller-cameraoverlayview-not-working-with-ipho
- Example 2: user is trying to show a shape on the screen to help the user take a photo in the right location:
https://github.com/jamesmontemagno/MediaPlugin/issues/377
Based on what this says, a developer can disable the default controls and then provide their own? https://stackoverflow.com/a/23887452/636479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] IllusionVK edited a comment on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
IllusionVK edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-1070614891
Hi @hajunho, so could you share the link to the other repo to help some other people ?
And could you help us to understand what cameraoverlayview is used for, and is the link that I included the correct one ?(https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] timbru31 edited a comment on pull request #715: (iOS) overlay view supporting to show the indicated image titled "overl…
Posted by GitBox <gi...@apache.org>.
timbru31 edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-camera/pull/715#issuecomment-803689683
Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org