svn commit: r1075014 - /wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java

[mg...@apache.org]

Author: mgrigorov
Date: Sun Feb 27 09:55:37 2011
New Revision: 1075014

URL: http://svn.apache.org/viewvc?rev=1075014&view=rev
Log:
WICKET-3477 Exception when setting session default timezone with GatherExtendedBrowserInfo

Add javadoc explaining that Session#getClientInfo() should not be called in custom Session's constructor.


Modified:
    wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java

Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java?rev=1075014&r1=1075013&r2=1075014&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/protocol/http/WebRequestCycle.java Sun Feb 27 09:55:37 2011
@@ -297,7 +297,17 @@ public class WebRequestCycle extends Req
 	}
 
 	/**
-	 * @see org.apache.wicket.RequestCycle#newClientInfo()
+	 * {@inheritDoc}
+	 * 
+	 * <p>
+	 * To gather the client information this implementation redirects temporarily to a special page
+	 * ({@link BrowserInfoPage}).
+	 * <p>
+	 * Note: Do <strong>not</strong> call this method from your custom {@link Session} constructor
+	 * because the temporary page needs a constructed {@link Session} to be able to work.
+	 * <p>
+	 * If you need to set a default client info property then better use
+	 * {@link Session#setClientInfo(org.apache.wicket.request.ClientInfo)} directly.
 	 */
 	@Override
 	protected ClientInfo newClientInfo()