[GitHub] [lucene-solr] janhoy commented on a change in pull request #1712: SOLR-14702: Remove oppressive language (part1)

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464357957



##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
       numberBackupsToKeep = 0;
     }
     @SuppressWarnings({"rawtypes"})
-    NamedList slave = (NamedList) initArgs.get("slave");
-    boolean enableSlave = isEnabled( slave );
-    if (enableSlave) {
-      currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave, this, core);
-      setupPolling((String) slave.get(POLL_INTERVAL));
-      isSlave = true;
+    NamedList secondary = (NamedList) initArgs.get("secondary");
+    boolean enableSecondary = isEnabled( secondary );
+    if (enableSecondary) {
+      currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary, this, core);
+      setupPolling((String) secondary.get(POLL_INTERVAL));
+      isSecondary = true;
     }
     @SuppressWarnings({"rawtypes"})
-    NamedList master = (NamedList) initArgs.get("master");
-    boolean enableMaster = isEnabled( master );
+    NamedList primary = (NamedList) initArgs.get("primary");

Review comment:
       We still promote rolling upgrade as the way to do upgrades in https://lucene.apache.org/solr/guide/8_6/upgrading-a-solr-cluster.html with no disclaimer about major versions. In the past we have strived to make a new major version be able to talk to previous major version. Could also let 8.7 support both and have the back-compat and require users to upgrade to 8.7 or later 8.x before doing rolling upgrade to 9.0. Or document that 8.x to 9.0 will not support rolling upgrade...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org