You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/07/19 19:54:10 UTC
Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/
-----------------------------------------------------------
Review request for mesos, Ian Downes and Timothy Chen.
Bugs: MESOS-3079
https://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
Diff: https://reviews.apache.org/r/36605/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/#review92213
-----------------------------------------------------------
Ship it!
- Joerg Schad
On July 19, 2015, 6:04 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36605/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 6:04 p.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Bugs: MESOS-3079
> https://issues.apache.org/jira/browse/MESOS-3079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
> src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
>
> Diff: https://reviews.apache.org/r/36605/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/#review92215
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On July 19, 2015, 6:04 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36605/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 6:04 p.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Bugs: MESOS-3079
> https://issues.apache.org/jira/browse/MESOS-3079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
> src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
>
> Diff: https://reviews.apache.org/r/36605/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/
-----------------------------------------------------------
(Updated July 19, 2015, 6:04 p.m.)
Review request for mesos, Ian Downes and Timothy Chen.
Bugs: MESOS-3079
https://issues.apache.org/jira/browse/MESOS-3079
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
Diff: https://reviews.apache.org/r/36605/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 19, 2015, 5:55 p.m., Timothy Chen wrote:
> > src/tests/cgroups_tests.cpp, line 992
> > <https://reviews.apache.org/r/36605/diff/1/?file=1016074#file1016074line992>
> >
> > I wonder what is the follow up action around this TODO? Seems like it stated why we commented the code but not anything we should do in the future?
Added the JIRA issue for tracking.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/#review92210
-----------------------------------------------------------
On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36605/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 5:54 p.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Bugs: MESOS-3079
> https://issues.apache.org/jira/browse/MESOS-3079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
> src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
>
> Diff: https://reviews.apache.org/r/36605/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 36605: Cleaned up 'perf' related tests to work on
Ubuntu 14.04.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36605/#review92210
-----------------------------------------------------------
src/tests/cgroups_tests.cpp (line 991)
<https://reviews.apache.org/r/36605/#comment146234>
I wonder what is the follow up action around this TODO? Seems like it stated why we commented the code but not anything we should do in the future?
src/tests/perf_tests.cpp (line 172)
<https://reviews.apache.org/r/36605/#comment146235>
ditto
- Timothy Chen
On July 19, 2015, 5:54 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36605/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 5:54 p.m.)
>
>
> Review request for mesos, Ian Downes and Timothy Chen.
>
>
> Bugs: MESOS-3079
> https://issues.apache.org/jira/browse/MESOS-3079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/cgroups_tests.cpp ac431beb04598d257aa98bef52a991585fe7f1ab
> src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
>
> Diff: https://reviews.apache.org/r/36605/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>