You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "atharvalade (via GitHub)" <gi...@apache.org> on 2026/03/07 21:42:44 UTC
[PR] test(java): add async-specific tests for ConsumerGroupsTcpClient [iggy]
atharvalade opened a new pull request, #2890:
URL: https://github.com/apache/iggy/pull/2890
## Which issue does this PR close?
Closes #2225
## Rationale
The async `ConsumerGroupsTcpClient` had no dedicated test coverage. While the blocking client had `ConsumerGroupsClientBaseTest` and `ConsumerGroupsTcpClientTest`, the async path only had a few scattered tests inside the monolithic `AsyncClientIntegrationTest`. Dedicated tests are needed to verify correct `CompletableFuture` semantics.
## What changed?
The async consumer groups client had no focused test class, leaving join/leave, error propagation, and concurrent `CompletableFuture` patterns untested.
Added `AsyncConsumerGroupsTest.java` with 17 tests covering all six API operations (create, get by id, get by name, list, delete by id, delete by name), join/leave membership including multi-client scenarios, error scenarios that assert `IggyResourceNotFoundException` propagates correctly through `ExecutionException`, and `CompletableFuture`-specific patterns such as `thenCompose` chaining and `allOf` concurrent operations.
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
1. Opus 4.6
2. Minimal usage: used for codebase exploration and initial scaffolding. All test logic, assertions, and cleanup patterns were reviewed and verified against existing test classes.
3. Ran the full test suite locally via `./gradlew :iggy:test` confirming 17/17 tests pass with 0 failures and no Netty resource leaks.
4. Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(java): add async-specific tests for ConsumerGroupsTcpClient [iggy]
Posted by "mmodzelewski (via GitHub)" <gi...@apache.org>.
mmodzelewski merged PR #2890:
URL: https://github.com/apache/iggy/pull/2890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(java): add async-specific tests for ConsumerGroupsTcpClient [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2890:
URL: https://github.com/apache/iggy/pull/2890#issuecomment-4017476090
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/2890?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 68.36%. Comparing base ([`33bee3d`](https://app.codecov.io/gh/apache/iggy/commit/33bee3db6242dc55ac162ec9fbe1a2f0dbdccd40?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4527127`](https://app.codecov.io/gh/apache/iggy/commit/452712758e888e395cc3050e4b07fd3ebe78fbd8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2890 +/- ##
============================================
+ Coverage 68.33% 68.36% +0.02%
- Complexity 739 743 +4
============================================
Files 1053 1053
Lines 84763 84763
Branches 61297 61297
============================================
+ Hits 57923 57947 +24
+ Misses 24468 24443 -25
- Partials 2372 2373 +1
```
| [Flag](https://app.codecov.io/gh/apache/iggy/pull/2890/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/iggy/pull/2890/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.42% <ø> (+0.58%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/2890/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org