You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by sc...@apache.org on 2025/04/01 12:49:53 UTC
(kafka) branch trunk updated: KAFKA-18796-2: Corrected the check for acquisition lock timeout in Sh… (#19338)
This is an automated email from the ASF dual-hosted git repository.
schofielaj pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 0c973389593 KAFKA-18796-2: Corrected the check for acquisition lock timeout in Sh… (#19338)
0c973389593 is described below
commit 0c9733895933cd43752f0d708e57b99037309975
Author: Chirag Wadhwa <12...@users.noreply.github.com>
AuthorDate: Tue Apr 1 18:19:47 2025 +0530
KAFKA-18796-2: Corrected the check for acquisition lock timeout in Sh… (#19338)
Minor PR to correct the check for the presence of acquisition lock in
`assertionFailedMessage` method in `SharePartitionTest`
Reviewers: Andrew Schofield <as...@confluent.io>
---
core/src/test/java/kafka/server/share/SharePartitionTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/core/src/test/java/kafka/server/share/SharePartitionTest.java b/core/src/test/java/kafka/server/share/SharePartitionTest.java
index 1f98a1d9211..354b9bb6c9f 100644
--- a/core/src/test/java/kafka/server/share/SharePartitionTest.java
+++ b/core/src/test/java/kafka/server/share/SharePartitionTest.java
@@ -6660,12 +6660,12 @@ public class SharePartitionTest {
for (Long offset : entry.getValue()) {
errorMessage.append(String.format("\toffset: %d, offset state: %s, offset acquisition lock timeout task present: %b\n",
offset, sharePartition.cachedState().get(entry.getKey()).offsetState().get(offset).state().id(),
- sharePartition.cachedState().get(entry.getKey()).offsetState().get(offset).acquisitionLockTimeoutTask() == null));
+ sharePartition.cachedState().get(entry.getKey()).offsetState().get(offset).acquisitionLockTimeoutTask() != null));
}
} else {
errorMessage.append(String.format("batch start offset: %d, batch state: %s, batch acquisition lock timeout task present: %b\n",
entry.getKey(), sharePartition.cachedState().get(entry.getKey()).batchState().id(),
- sharePartition.cachedState().get(entry.getKey()).batchAcquisitionLockTimeoutTask() == null));
+ sharePartition.cachedState().get(entry.getKey()).batchAcquisitionLockTimeoutTask() != null));
}
}
return errorMessage.toString();