You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/03/22 02:14:58 UTC
[GitHub] [phoenix] lhofhansl opened a new pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
lhofhansl opened a new pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177
See Jira. In the SELECT CF1.* WHERE CF2.C ... cannot use the EncodedQualifiersColumnProjectionFilter since the number of qualifiers is not know (so the trackcolumns Bitset cannot be build ahead of time).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on a change in pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on a change in pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#discussion_r598972129
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/EncodedColumnsUtil.java
##########
@@ -133,7 +133,7 @@ public static boolean useEncodedQualifierListOptimization(PTable table, Scan sca
* Disabling this optimization for tables with more than one column family.
* See PHOENIX-3890.
*/
- return !scan.isRaw() && table.getColumnFamilies().size() <= 1 && table.getImmutableStorageScheme() != null
Review comment:
This inadvertently caught local indexes too (which have 0 column families declared in their table definition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl merged pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl merged pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#discussion_r598461392
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##########
@@ -496,6 +496,10 @@ private static void optimizeProjection(StatementContext context, Scan scan, PTab
trackedColumnsBitset.set(qualifier);
}
}
+ } else {
+ // cannot use EncodedQualifiersColumnProjectionFilter in this case
+ // since there's an unknown set of qualifiers (cf.*)
+ trackedColumnsBitset = null;
Review comment:
Yeah I think this makes sense, and hopefully should work for multiple filters too. Shall we add one more test to cover multiple cols and filters? Something like
`SELECT w.*, x.* FROM tableName WHERE y.v2='xyz' and z.v3='abc'` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804474642
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 38s | master passed |
| +0 | hbaserecompile | 22m 4s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 3s | master passed |
| +1 :green_heart: | checkstyle | 0m 53s | master passed |
| +1 :green_heart: | javadoc | 0m 54s | master passed |
| +0 :ok: | spotbugs | 3m 3s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 13s | the patch passed |
| +0 | hbaserecompile | 17m 31s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 1s | the patch passed |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | phoenix-core: The patch generated 16 new + 833 unchanged - 15 fixed = 849 total (was 848) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 51s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 14s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 105m 28s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. |
| | | 158m 12s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionNSEnabledIT |
| | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1177 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux 90e46aeea902 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 84d91ff |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/testReport/ |
| Max. process+thread count | 13966 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804398015
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 14s | master passed |
| +0 | hbaserecompile | 27m 18s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 2s | master passed |
| +1 :green_heart: | checkstyle | 0m 53s | master passed |
| +1 :green_heart: | javadoc | 0m 51s | master passed |
| +0 :ok: | spotbugs | 3m 6s | phoenix-core in master has 956 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 8s | the patch passed |
| +0 | hbaserecompile | 17m 35s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 4s | the patch passed |
| +1 :green_heart: | javac | 1m 4s | the patch passed |
| -1 :x: | checkstyle | 0m 53s | phoenix-core: The patch generated 16 new + 833 unchanged - 15 fixed = 849 total (was 848) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 52s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 12s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 107m 52s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. |
| | | 171m 9s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1177 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux baa7eaee37b1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 84d91ff |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/testReport/ |
| Max. process+thread count | 13878 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804289316
Added more tests as @virajjasani suggested. Also added local indexes to the test, and included an additional fix for local indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on a change in pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on a change in pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#discussion_r598867205
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
##########
@@ -496,6 +496,10 @@ private static void optimizeProjection(StatementContext context, Scan scan, PTab
trackedColumnsBitset.set(qualifier);
}
}
+ } else {
+ // cannot use EncodedQualifiersColumnProjectionFilter in this case
+ // since there's an unknown set of qualifiers (cf.*)
+ trackedColumnsBitset = null;
Review comment:
Yeah... Lemme add that test and then merge.
Thanks @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-803760106
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 40s | master passed |
| +0 | hbaserecompile | 22m 9s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 0s | master passed |
| +1 :green_heart: | checkstyle | 0m 49s | master passed |
| +1 :green_heart: | javadoc | 0m 52s | master passed |
| +0 :ok: | spotbugs | 3m 3s | phoenix-core in master has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 13s | the patch passed |
| +0 | hbaserecompile | 17m 40s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 2s | the patch passed |
| +1 :green_heart: | javac | 1m 2s | the patch passed |
| -1 :x: | checkstyle | 0m 50s | phoenix-core: The patch generated 15 new + 720 unchanged - 14 fixed = 735 total (was 734) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 15s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 106m 45s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. |
| | | 163m 23s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1177 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile |
| uname | Linux d2443e3856be 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / b5bea88 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/testReport/ |
| Max. process+thread count | 12917 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1177/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804207248
I'll also check the test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-805107100
Thanks @virajjasani
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804399784
Last test run still looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804214543
Actually... When I add local indexes into the mix it still fails for another reason. I'll look into that as well. If it's an easy fix I'll add it here otherwise I'll file another jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] lhofhansl commented on pull request #1177: PHOENIX-6424 SELECT cf1.* FAILS with a WHERE clause including cf2.
Posted by GitBox <gi...@apache.org>.
lhofhansl commented on pull request #1177:
URL: https://github.com/apache/phoenix/pull/1177#issuecomment-804306330
Expanded the test slightly to also do a CF.* from a column family with an indexed column.
This should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org