You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Hexiaoqiao (via GitHub)" <gi...@apache.org> on 2023/09/12 04:46:29 UTC

[GitHub] [hadoop] Hexiaoqiao commented on pull request #6052: HADOOP-18824. ZKDelegationTokenSecretManager causes ArithmeticException due to improper numRetries value checking

Hexiaoqiao commented on PR #6052:
URL: https://github.com/apache/hadoop/pull/6052#issuecomment-1714957880

   LGTM.
   
   > set zk-dt-secret-manager.zkNumRetries=0
   > run org.apache.hadoop.security.token.delegation.TestZKDelegationTokenSecretManager.testMultiNodeOperations
   > The test passes rather than throwing division by zero.
   
   Would you mind to add this case as unit test to cover it? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org