You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:41:49 UTC
[GitHub] [guacamole-client] XYUU opened a new pull request #518: GUACAMOLE-903: Improved Chinese internationalization support
XYUU opened a new pull request #518:
URL: https://github.com/apache/guacamole-client/pull/518
https://github.com/apache/guacamole-client/pull/453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] XYUU commented on a change in pull request #518: GUACAMOLE-903: Improved Chinese internationalization support
Posted by GitBox <gi...@apache.org>.
XYUU commented on a change in pull request #518:
URL: https://github.com/apache/guacamole-client/pull/518#discussion_r437339734
##########
File path: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/guac-manifest.json
##########
@@ -24,7 +24,8 @@
"translations/es.json",
"translations/fr.json",
"translations/ja.json",
- "translations/ru.json"
+ "translations/ru.json",
+ "translations/zh.json"
Review comment:
okay，I add。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] XYUU closed pull request #518: GUACAMOLE-903: Improved Chinese internationalization support
Posted by GitBox <gi...@apache.org>.
XYUU closed pull request #518:
URL: https://github.com/apache/guacamole-client/pull/518
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #518: GUACAMOLE-903: Improved Chinese internationalization support
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #518:
URL: https://github.com/apache/guacamole-client/pull/518#discussion_r437328404
##########
File path: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/guac-manifest.json
##########
@@ -24,7 +24,8 @@
"translations/es.json",
"translations/fr.json",
"translations/ja.json",
- "translations/ru.json"
+ "translations/ru.json",
+ "translations/zh.json"
Review comment:
Shouldn't this also be added to the `guac-manifest.json` file for PostgreSQL and SQL Server?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org