You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Igor Kryvenko <kr...@gmail.com> on 2018/03/31 14:17:24 UTC

Review Request 66381: HIVE-18905: HS2: SASL auth loads HiveConf for every JDBC call

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66381/
-----------------------------------------------------------

Review request for hive, Ashutosh Chauhan and Gopal V.


Bugs: HIVE-18905
    https://issues.apache.org/jira/browse/HIVE-18905


Repository: hive-git


Description
-------

SASL authentication filter does a new HiveConf() for no good reason.


Diffs
-----

  service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java c684318986b028a92c255a087d8375b08557faf1 
  service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java 3d7ccd96feaacfc36d262d3396e97a7982921fb1 
  service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java 73bbb6bdf8af451d78ac72a58da91f2285d81a79 
  service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java fff378a7e9e7183d6e27ca229535168eda349d3f 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java 70ffa3c6a3ad5d447f1d2dc2ebb9be20e22be10d 


Diff: https://reviews.apache.org/r/66381/diff/1/


Testing
-------


Thanks,

Igor Kryvenko


Re: Review Request 66381: HIVE-18905: HS2: SASL auth loads HiveConf for every JDBC call

Posted by Igor Kryvenko <kr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66381/
-----------------------------------------------------------

(Updated Апрель 5, 2018, 9:32 п.п.)


Review request for hive, Ashutosh Chauhan and Gopal V.


Changes
-------

Fixing checkstyle


Bugs: HIVE-18905
    https://issues.apache.org/jira/browse/HIVE-18905


Repository: hive-git


Description
-------

SASL authentication filter does a new HiveConf() for no good reason.


Diffs (updated)
-----

  service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java c684318986b028a92c255a087d8375b08557faf1 
  service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java 3d7ccd96feaacfc36d262d3396e97a7982921fb1 
  service/src/java/org/apache/hive/service/auth/LdapAuthenticationProviderImpl.java 73bbb6bdf8af451d78ac72a58da91f2285d81a79 
  service/src/java/org/apache/hive/service/auth/PamAuthenticationProviderImpl.java fff378a7e9e7183d6e27ca229535168eda349d3f 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java 70ffa3c6a3ad5d447f1d2dc2ebb9be20e22be10d 


Diff: https://reviews.apache.org/r/66381/diff/2/

Changes: https://reviews.apache.org/r/66381/diff/1-2/


Testing
-------


Thanks,

Igor Kryvenko