You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/03/27 19:44:00 UTC
Review Request 57968: Prune files contained in jcepolicyinfo.jar to a
minimal set
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
Bugs: AMBARI-20544
https://issues.apache.org/jira/browse/AMBARI-20544
Repository: ambari
Description
-------
Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
Diffs
-----
ambari-agent/pom.xml 292fd07
Diff: https://reviews.apache.org/r/57968/diff/1/
Testing
-------
Manualy tested jar.
Thanks,
Robert Levas
Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar
to a minimal set
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/#review170315
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On March 28, 2017, 3:20 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57968/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 3:20 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20544
> https://issues.apache.org/jira/browse/AMBARI-20544
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
>
> The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57968/diff/2/
>
>
> Testing
> -------
>
> Manualy tested jar.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar
to a minimal set
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/#review170317
-----------------------------------------------------------
Ship it!
Ship It!
- Eugene Chekanskiy
On March 28, 2017, 3:20 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57968/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 3:20 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20544
> https://issues.apache.org/jira/browse/AMBARI-20544
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
>
> The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57968/diff/2/
>
>
> Testing
> -------
>
> Manualy tested jar.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar
to a minimal set
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/
-----------------------------------------------------------
(Updated March 28, 2017, 11:20 a.m.)
Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
Changes
-------
Updated patch to _include_ required JARs rather than _exclude_ unneeded JARs.
Bugs: AMBARI-20544
https://issues.apache.org/jira/browse/AMBARI-20544
Repository: ambari
Description
-------
Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
Diffs (updated)
-----
ambari-agent/pom.xml 292fd07
Diff: https://reviews.apache.org/r/57968/diff/2/
Changes: https://reviews.apache.org/r/57968/diff/1-2/
Testing
-------
Manualy tested jar.
Thanks,
Robert Levas
Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar
to a minimal set
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/#review170266
-----------------------------------------------------------
ambari-agent/pom.xml
Lines 420 (patched)
<https://reviews.apache.org/r/57968/#comment243067>
Maybe doing it the other way around and including only the dependencies what are needed instead of what are not needed would be more robust. When I added the zkmigrator, there were only 2 dependencies in the pom.xml, since then someone added hadoop-common and 5 others. If we'll keep adding new dependnecies this exclude list will need to be maintained.
- Attila Magyar
On March 27, 2017, 7:43 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57968/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 7:43 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20544
> https://issues.apache.org/jira/browse/AMBARI-20544
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
>
> The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57968/diff/1/
>
>
> Testing
> -------
>
> Manualy tested jar.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar
to a minimal set
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57968/#review170260
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On March 27, 2017, 9:43 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57968/
> -----------------------------------------------------------
>
> (Updated March 27, 2017, 9:43 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Bal�zs Bence S�ri, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.
>
>
> Bugs: AMBARI-20544
> https://issues.apache.org/jira/browse/AMBARI-20544
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Prune files contained in the Ambari agent jcepolicyinfo.jar file to a minimal set.
>
> The files (classes, etcs...) in the _shaded_ JAR come from unrelated or unneeded dependencies. This is causing bloat and may cause unnecessary licensing issues.
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml 292fd07
>
>
> Diff: https://reviews.apache.org/r/57968/diff/1/
>
>
> Testing
> -------
>
> Manualy tested jar.
>
>
> Thanks,
>
> Robert Levas
>
>