You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/09/03 13:19:41 UTC
[dubbo] branch 3.0 updated: [3.0] Statement lambda can be replaced
with expression lambda (#8667)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/3.0 by this push:
new 82f9a6b [3.0] Statement lambda can be replaced with expression lambda (#8667)
82f9a6b is described below
commit 82f9a6b583a91985eadff182f98778537becf979
Author: Wang Chengming <63...@qq.com>
AuthorDate: Fri Sep 3 21:17:23 2021 +0800
[3.0] Statement lambda can be replaced with expression lambda (#8667)
* Statement lambda can be replaced with expression lambda
* format code
---
.../registry/nacos/NacosServiceDiscovery.java | 38 ++++++++++------------
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosServiceDiscovery.java b/dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosServiceDiscovery.java
index 0048ca7..21817da 100644
--- a/dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosServiceDiscovery.java
+++ b/dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosServiceDiscovery.java
@@ -111,28 +111,26 @@ public class NacosServiceDiscovery extends AbstractServiceDiscovery {
public List<ServiceInstance> getInstances(String serviceName) throws NullPointerException {
return ThrowableFunction.execute(namingService, service ->
service.selectInstances(serviceName, Constants.DEFAULT_GROUP, true)
- .stream().map((i)->NacosNamingServiceUtils.toServiceInstance(registryURL, i))
- .collect(Collectors.toList())
+ .stream().map((i) -> NacosNamingServiceUtils.toServiceInstance(registryURL, i))
+ .collect(Collectors.toList())
);
}
@Override
public void addServiceInstancesChangedListener(ServiceInstancesChangedListener listener)
- throws NullPointerException, IllegalArgumentException {
- execute(namingService, service -> {
- listener.getServiceNames().forEach(serviceName -> {
- try {
- service.subscribe(serviceName, Constants.DEFAULT_GROUP, e -> { // Register Nacos EventListener
- if (e instanceof NamingEvent) {
- NamingEvent event = (NamingEvent) e;
- handleEvent(event, listener);
- }
- });
- } catch (NacosException e) {
- logger.error("add nacos service instances changed listener fail ", e);
- }
- });
- });
+ throws NullPointerException, IllegalArgumentException {
+ execute(namingService, service -> listener.getServiceNames().forEach(serviceName -> {
+ try {
+ service.subscribe(serviceName, Constants.DEFAULT_GROUP, e -> { // Register Nacos EventListener
+ if (e instanceof NamingEvent) {
+ NamingEvent event = (NamingEvent) e;
+ handleEvent(event, listener);
+ }
+ });
+ } catch (NacosException e) {
+ logger.error("add nacos service instances changed listener fail ", e);
+ }
+ }));
}
@Override
@@ -143,9 +141,9 @@ public class NacosServiceDiscovery extends AbstractServiceDiscovery {
private void handleEvent(NamingEvent event, ServiceInstancesChangedListener listener) {
String serviceName = event.getServiceName();
List<ServiceInstance> serviceInstances = event.getInstances()
- .stream()
- .map((i)->NacosNamingServiceUtils.toServiceInstance(registryURL, i))
- .collect(Collectors.toList());
+ .stream()
+ .map((i) -> NacosNamingServiceUtils.toServiceInstance(registryURL, i))
+ .collect(Collectors.toList());
listener.onEvent(new ServiceInstancesChangedEvent(serviceName, serviceInstances));
}
}