You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/17 12:01:22 UTC
[GitHub] [pulsar-helm-chart] NiklasWagner opened a new pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
NiklasWagner opened a new pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42
### Motivation
We're hosting our Pulsar Cluster in kubernetes but most of the actual clients are running on a different infrastructure. To expose the pulsar proxy and the pulsar manager we need a ingress resource.
### Modifications
I've copied the dashboard-ingress.yaml and adjusted the variable references and added some logic to support TLS configurations.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] NiklasWagner commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
NiklasWagner commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660802037
@sijie Is there anything left to do to get this merged? We're already using these changes for a couple weeks in production and would love to switch back to this helm chart repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] rvashishth commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
rvashishth commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660074223
@NiklasWagner would it be a good idea to create a single ingress resource for all HTTP services( proxy admin API, Grafana, and pulsar-manager) instead of creating multiple ingresses for each component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] NiklasWagner commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
NiklasWagner commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660822796
Thanks! :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] rvashishth commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
rvashishth commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660082554
I assume the idea behind ingress to have a single entry point in the k8s cluster. having one ingress-resource per service my not be feasible. I was hoping something as below
<img width="631" alt="Screenshot 2020-07-17 at 6 03 51 PM" src="https://user-images.githubusercontent.com/6093884/87786635-eb15b600-c857-11ea-8df0-329dbcfe5546.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie merged pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] NiklasWagner commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
NiklasWagner commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660087223
Ah that what you mean. We're actually using a ingress controller for that which is what most people are doing. We've many ingress resources from many different charts and our nginx ingress is taking care of that. We're not creating a LB for each ingress on our cloud provider.
Additionally: Combining this in a single ingress resource would make it more complex for the ingress controller to correctly route the traffic. I think it would even make it impossible for us to work correctly since we're also using [external-dns](https://github.com/kubernetes-sigs/external-dns) to sync the hosts from the different ingress resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] NiklasWagner commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
NiklasWagner commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660075717
I'm not so sure. It would increase the complexity if there is a edge case (for example tls on a different port) and actually there are already 10 *-service.yaml files. So it doesn't hurt if there are some more ingress files :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on pull request #42: Add Ingress to Pulsar Proxy and Pulsar Manager
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #42:
URL: https://github.com/apache/pulsar-helm-chart/pull/42#issuecomment-660822942
@NiklasWagner thank you for your contributions!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org