You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by Jacek Laskowski <ja...@laskowski.net.pl> on 2007/04/20 16:06:41 UTC

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

On 4/20/07, Continuum@vmbuild.apache.org
<op...@incubator.apache.org> wrote:
> Online report : http://vmbuild.apache.org/continuum/servlet/continuum/target/ProjectBuild.vm/view/ProjectBuild/id/160/buildId/117993
> Build statistics:
>   State: Failed
>   Previous State: Ok
>   Started at: Fri, 20 Apr 2007 06:59:50 -0700
>   Finished at: Fri, 20 Apr 2007 06:59:57 -0700
>   Total time: 6s
>   Build Trigger: Schedule
>   Exit code: 1
>   Building machine hostname: vmbuild.apache.org
>   Operating system : Linux(unknown)
>   Java version : 1.5.0_06(Sun Microsystems Inc.)
>
> Changes
>          jlaskowski          FakeTest no longer necessary (never been)
>              /incubator/openejb/trunk/openejb3/container/openejb-javaagent/pom.xml
>             /incubator/openejb/trunk/openejb3/container/openejb-javaagent/src/test
>
> ****************************************************************************
> Output:
> ****************************************************************************
> [INFO] Scanning for projects...
> [INFO] ----------------------------------------------------------------------------
> [INFO] Building OpenEJB :: Container :: Java Agent
> [INFO]    task-segment: [install]
> [INFO] ----------------------------------------------------------------------------
> [INFO] [resources:resources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:compile]
> [INFO] Nothing to compile - all classes are up to date
> [INFO] [resources:testResources]
> [INFO] Using default encoding to copy filtered resources.
> [INFO] [compiler:testCompile]
> [INFO] No sources to compile
> [INFO] [surefire:test]
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] No Java test frameworks found

I wonder what M2 version is used there or more specifically what
surefire version there is. I don't bark while executing on my laptop.
Will look into it unless someone beats me to it (which would be more
than welcome ;-))

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/21/07, Jacek Laskowski <ja...@laskowski.net.pl> wrote:
> On 4/21/07, Jason Dillon <ja...@planet57.com> wrote:
> > You guys really shouldn't need a dummy test in there.  Maven should
> > be skipping tests if the src/test directory is not present.  If not
> > its a bug, though you can easily work around this by adding this to
> > your pom:
> >
> >      <properties>
> >          <maven.test.skip>true</maven.test.skip>
> >      </properties>
> >
> > And then drop the src/test dir and the junit dep in the pom.
>
> That's the idea! Thanks Jason. I was not very happy to keep dummy test
> just to satisfy m2 (unreasonable) requirements.

Committed the change and verified it built on Continuum. Sorry again
for the mess before. Thanks Jason for your help and Dain for his
patience!

/me is happy to be able to learn new stuff each day

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/21/07, Jason Dillon <ja...@planet57.com> wrote:
> You guys really shouldn't need a dummy test in there.  Maven should
> be skipping tests if the src/test directory is not present.  If not
> its a bug, though you can easily work around this by adding this to
> your pom:
>
>      <properties>
>          <maven.test.skip>true</maven.test.skip>
>      </properties>
>
> And then drop the src/test dir and the junit dep in the pom.

That's the idea! Thanks Jason. I was not very happy to keep dummy test
just to satisfy m2 (unreasonable) requirements.

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Dain Sundstrom <da...@iq80.com>.
On Apr 21, 2007, at 4:08 AM, Jacek Laskowski wrote:

> On 4/21/07, Dain Sundstrom <da...@iq80.com> wrote:
>
>> It is a non-testable feature.  It is a javaagent which requires a jar
>> to test and then it just gives you a handle to the instrumentation
>> stuff.
>
> Well, I think that everything's testable, but perhaps not as easy as
> the rest of the stuff. How do you know it works? Haven't you been
> doing some tests with javaagent to see whether it worked or not? I'd
> bet you did. That's the test, isn't it?

The code is tested in the core module.  It is a very low level piece  
of code, and if it is not working all of JPA and thus CMP stops working.

-dain

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/21/07, Dain Sundstrom <da...@iq80.com> wrote:

> It is a non-testable feature.  It is a javaagent which requires a jar
> to test and then it just gives you a handle to the instrumentation
> stuff.

Well, I think that everything's testable, but perhaps not as easy as
the rest of the stuff. How do you know it works? Haven't you been
doing some tests with javaagent to see whether it worked or not? I'd
bet you did. That's the test, isn't it?

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jason Dillon <ja...@planet57.com>.
Aighty then, I'd drop the junit deps and set maven.test.skip=true for  
it if it still isn't happy w/o the src/test dir.

--jason


On Apr 20, 2007, at 5:08 PM, Dain Sundstrom wrote:

> On Apr 20, 2007, at 4:10 PM, Jason Dillon wrote:
>
>> You guys really shouldn't need a dummy test in there.  Maven  
>> should be skipping tests if the src/test directory is not  
>> present.  If not its a bug, though you can easily work around this  
>> by adding this to your pom:
>>
>>     <properties>
>>         <maven.test.skip>true</maven.test.skip>
>>     </properties>
>>
>> And then drop the src/test dir and the junit dep in the pom.
>>
>>  * * *
>>
>> Or maybe add some real tests :-P
>
> It is a non-testable feature.  It is a javaagent which requires a  
> jar to test and then it just gives you a handle to the  
> instrumentation stuff.
>
> -dain


Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Dain Sundstrom <da...@iq80.com>.
On Apr 20, 2007, at 4:10 PM, Jason Dillon wrote:

> You guys really shouldn't need a dummy test in there.  Maven should  
> be skipping tests if the src/test directory is not present.  If not  
> its a bug, though you can easily work around this by adding this to  
> your pom:
>
>     <properties>
>         <maven.test.skip>true</maven.test.skip>
>     </properties>
>
> And then drop the src/test dir and the junit dep in the pom.
>
>  * * *
>
> Or maybe add some real tests :-P

It is a non-testable feature.  It is a javaagent which requires a jar  
to test and then it just gives you a handle to the instrumentation  
stuff.

-dain

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jason Dillon <ja...@planet57.com>.
You guys really shouldn't need a dummy test in there.  Maven should  
be skipping tests if the src/test directory is not present.  If not  
its a bug, though you can easily work around this by adding this to  
your pom:

     <properties>
         <maven.test.skip>true</maven.test.skip>
     </properties>

And then drop the src/test dir and the junit dep in the pom.

  * * *

Or maybe add some real tests :-P

--jason


On Apr 20, 2007, at 3:33 PM, Jacek Laskowski wrote:

> On 4/20/07, Dain Sundstrom <da...@iq80.com> wrote:
>> I added it back, because I couldn't build anything without it.
>
> Thanks Dain and sorry for the breakage.
>
> Jacek
>
> -- 
> Jacek Laskowski
> http://www.JacekLaskowski.pl


Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/20/07, Dain Sundstrom <da...@iq80.com> wrote:
> I added it back, because I couldn't build anything without it.

Thanks Dain and sorry for the breakage.

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Dain Sundstrom <da...@iq80.com>.
I added it back, because I couldn't build anything without it.

-dain

On Apr 20, 2007, at 9:56 AM, Dain Sundstrom wrote:

> On Apr 20, 2007, at 9:50 AM, Jacek Laskowski wrote:
>
>> On 4/20/07, Dain Sundstrom <da...@iq80.com> wrote:
>>
>>> Please put it back.  Maven seems to blow up randomly when there are
>>> no tests in a module.
>>
>> Ok, will do if there's no better way to sort it out. That's why I
>> committed the changes one by one so it's easier to revert a change.
>>
>> Do you happen to remember what the command is?
>
> Nope.  With small changes like this, I tend to just type it back in :)
>
> -dain


Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Dain Sundstrom <da...@iq80.com>.
On Apr 20, 2007, at 9:50 AM, Jacek Laskowski wrote:

> On 4/20/07, Dain Sundstrom <da...@iq80.com> wrote:
>
>> Please put it back.  Maven seems to blow up randomly when there are
>> no tests in a module.
>
> Ok, will do if there's no better way to sort it out. That's why I
> committed the changes one by one so it's easier to revert a change.
>
> Do you happen to remember what the command is?

Nope.  With small changes like this, I tend to just type it back in :)

-dain

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 4/20/07, Dain Sundstrom <da...@iq80.com> wrote:

> Please put it back.  Maven seems to blow up randomly when there are
> no tests in a module.

Ok, will do if there's no better way to sort it out. That's why I
committed the changes one by one so it's easier to revert a change.

Do you happen to remember what the command is?

Jacek

-- 
Jacek Laskowski
http://www.JacekLaskowski.pl

Re: [continuum] BUILD FAILURE: OpenEJB :: Container :: Java Agent

Posted by Dain Sundstrom <da...@iq80.com>.
On Apr 20, 2007, at 7:06 AM, Jacek Laskowski wrote:

>> Changes
>>          jlaskowski          FakeTest no longer necessary (never  
>> been)
>>              /incubator/openejb/trunk/openejb3/container/openejb- 
>> javaagent/pom.xml
>>             /incubator/openejb/trunk/openejb3/container/openejb- 
>> javaagent/src/test
>>
>> [INFO]  
>> --------------------------------------------------------------------- 
>> ---
>> [ERROR] BUILD ERROR
>> [INFO]  
>> --------------------------------------------------------------------- 
>> ---
>> [INFO] No Java test frameworks found
>
> I wonder what M2 version is used there or more specifically what
> surefire version there is. I don't bark while executing on my laptop.
> Will look into it unless someone beats me to it (which would be more
> than welcome ;-))

Please put it back.  Maven seems to blow up randomly when there are  
no tests in a module.

-dain