You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/31 12:43:44 UTC
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #7826: [IOTDB-4791] Optimize the endFile in `TsFileIOWriter`
xingtanzjr commented on code in PR #7826:
URL: https://github.com/apache/iotdb/pull/7826#discussion_r1009372540
##########
tsfile/src/main/java/org/apache/iotdb/tsfile/read/common/Path.java:
##########
@@ -93,11 +93,18 @@ public Path(String pathSc, boolean needSplit) {
*
* @param device root.deviceType.d1
* @param measurement s1 , does not contain TsFileConstant.PATH_SEPARATOR
+ * @param needCheck need to validate the correctness of the path
*/
- public Path(String device, String measurement) {
+ public Path(String device, String measurement, boolean needCheck) {
if (device == null || measurement == null) {
throw new PathParseException(ILLEGAL_PATH_ARGUMENT);
}
+ if (!needCheck) {
+ this.measurement = measurement;
+ this.device = device;
+ this.fullPath = device + "." + measurement;
Review Comment:
Using `StringBuilder` or some other ways to avoid `+`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org