You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/22 12:55:30 UTC
[GitHub] [hive] lcspinter opened a new pull request, #3236: HIVE-26169: Set non-vectorized mode as default when accessing iceberg tables in avro fileformat
lcspinter opened a new pull request, #3236:
URL: https://github.com/apache/hive/pull/3236
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Set vectorization to false when reading/writing iceberg tables in avro format.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Vectorization for iceberg tables in avro is not yet supported.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Manual test, unit test
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter merged pull request #3236: HIVE-26169: Set non-vectorized mode as default when accessing iceberg tables in avro fileformat
Posted by GitBox <gi...@apache.org>.
lcspinter merged PR #3236:
URL: https://github.com/apache/hive/pull/3236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] marton-bod commented on a diff in pull request #3236: HIVE-26169: Set non-vectorized mode as default when accessing iceberg tables in avro fileformat
Posted by GitBox <gi...@apache.org>.
marton-bod commented on code in PR #3236:
URL: https://github.com/apache/hive/pull/3236#discussion_r856213274
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -744,8 +745,17 @@ private String collectColumnAndReplaceDummyValues(ExprNodeDesc node, String foun
return column;
}
- private void fallbackToNonVectorizedModeForV2(Properties tableProps) {
- if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION))) {
+ /**
+ * If any of the following checks is true we fall back to non vectorized mode:
+ * <ul>
+ * <li>iceberg format-version is "2"</li>
+ * <li>fileformat is set to avro</li>
+ * </ul>
+ * @param tableProps table properties, must be not null
+ */
+ private void fallbackToNonVectorizedModeBasedOnProperties(Properties tableProps) {
+ if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION)) ||
+ FileFormat.AVRO.name().equalsIgnoreCase((String) tableProps.get(TableProperties.DEFAULT_FILE_FORMAT))) {
Review Comment:
nit: you can use `tablePros.getProperty()` instead of casting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on a diff in pull request #3236: HIVE-26169: Set non-vectorized mode as default when accessing iceberg tables in avro fileformat
Posted by GitBox <gi...@apache.org>.
lcspinter commented on code in PR #3236:
URL: https://github.com/apache/hive/pull/3236#discussion_r856217749
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -744,8 +745,17 @@ private String collectColumnAndReplaceDummyValues(ExprNodeDesc node, String foun
return column;
}
- private void fallbackToNonVectorizedModeForV2(Properties tableProps) {
- if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION))) {
+ /**
+ * If any of the following checks is true we fall back to non vectorized mode:
+ * <ul>
+ * <li>iceberg format-version is "2"</li>
+ * <li>fileformat is set to avro</li>
+ * </ul>
+ * @param tableProps table properties, must be not null
+ */
+ private void fallbackToNonVectorizedModeBasedOnProperties(Properties tableProps) {
+ if ("2".equals(tableProps.get(TableProperties.FORMAT_VERSION)) ||
+ FileFormat.AVRO.name().equalsIgnoreCase((String) tableProps.get(TableProperties.DEFAULT_FILE_FORMAT))) {
Review Comment:
yepp, fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org