You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by daan Hoogland <da...@gmail.com> on 2014/05/30 22:39:17 UTC
Review Request 22093: VPC's VR missing public NIC eth1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/
-----------------------------------------------------------
Review request for cloudstack and Marcus Sorensen.
Repository: cloudstack-git
Description
-------
VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
Diff: https://reviews.apache.org/r/22093/diff/
Testing
-------
Thanks,
daan Hoogland
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
> On June 2, 2014, 8:32 a.m., Joris van Lieshout wrote:
> > Another issue might be that new entries (we see this on ACS 4.3 with XenServer) are created without vlan://
> > The name of the field is vlan_id and not BroadcastURI so keeping it an integer only would make more sense to me. And then use null for untagged vlans. If we would really want a bURI then we should also rename the field.
You are right but that is a different issue. The field is a string type and called id. This is kind of against the acs db conventions.
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44480
-----------------------------------------------------------
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44480
-----------------------------------------------------------
Another issue might be that new entries (we see this on ACS 4.3 with XenServer) are created without vlan://
The name of the field is vlan_id and not BroadcastURI so keeping it an integer only would make more sense to me. And then use null for untagged vlans. If we would really want a bURI then we should also rename the field.
- Joris van Lieshout
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
> On June 2, 2014, 8:37 a.m., Erik Weber wrote:
> > engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java, line 368
> > <https://reviews.apache.org/r/22093/diff/2/?file=600082#file600082line368>
> >
> > There's a typo in the where clause. vland_id should be vlan_id
thanks, will fix
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44481
-----------------------------------------------------------
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Erik Weber <te...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44481
-----------------------------------------------------------
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java
<https://reviews.apache.org/r/22093/#comment78894>
There's a typo in the where clause. vland_id should be vlan_id
- Erik Weber
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Andrija Panic <an...@gmail.com>.
Seems like I'm going to keep my eyes on issues...for now.
Thanks
Sent from Google Nexus 4
On Jun 7, 2014 6:02 PM, "Daan Hoogland" <da...@gmail.com> wrote:
> Andrija,
>
> Please test upgrades if you can do them in lab envs. If not. just keep
> reporting on issues as you encounter them. If you are skilled at java
> you could isolate the upgrade step from the code in 4.4 resulting of
> the patch and run it against your branch. You would need to feel very
> comfortable with your env, (my)sql and java.
>
> regards,
>
> On Sat, Jun 7, 2014 at 5:50 PM, Andrija Panic <an...@gmail.com>
> wrote:
> > Hi Daan,
> > any help needed by me, regarding testing ? Did not catch these automated
> > emails...
> >
> > Thanks,
> > Andrija
> >
> >
> > On 7 June 2014 10:23, daan Hoogland <da...@gmail.com> wrote:
> >>
> >>
> >> -----------------------------------------------------------
> >>
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/22093/
> >> -----------------------------------------------------------
> >>
> >> (Updated June 7, 2014, 8:23 a.m.)
> >>
> >>
> >>
> >> Review request for cloudstack and Marcus Sorensen.
> >>
> >>
> >> Repository: cloudstack-git
> >>
> >>
> >> Description
> >> -------
> >>
> >>
> >> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by
> >> updating on upgrade
> >>
> >> This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
> >>
> >>
> >> Diffs
> >> -----
> >>
> >> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
> >>
> >> Diff: https://reviews.apache.org/r/22093/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >>
> >> live testing by Andrija Panic
> >>
> >>
> >> Thanks,
> >>
> >> daan Hoogland
> >>
> >
> >
> >
> > --
> >
> > Andrija Panić
> > --------------------------------------
> > http://admintweets.com
> > --------------------------------------
>
>
>
> --
> Daan
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Daan Hoogland <da...@gmail.com>.
Andrija,
Please test upgrades if you can do them in lab envs. If not. just keep
reporting on issues as you encounter them. If you are skilled at java
you could isolate the upgrade step from the code in 4.4 resulting of
the patch and run it against your branch. You would need to feel very
comfortable with your env, (my)sql and java.
regards,
On Sat, Jun 7, 2014 at 5:50 PM, Andrija Panic <an...@gmail.com> wrote:
> Hi Daan,
> any help needed by me, regarding testing ? Did not catch these automated
> emails...
>
> Thanks,
> Andrija
>
>
> On 7 June 2014 10:23, daan Hoogland <da...@gmail.com> wrote:
>>
>>
>> -----------------------------------------------------------
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/22093/
>> -----------------------------------------------------------
>>
>> (Updated June 7, 2014, 8:23 a.m.)
>>
>>
>>
>> Review request for cloudstack and Marcus Sorensen.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>>
>> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by
>> updating on upgrade
>>
>> This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
>>
>>
>> Diffs
>> -----
>>
>> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>>
>> Diff: https://reviews.apache.org/r/22093/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> live testing by Andrija Panic
>>
>>
>> Thanks,
>>
>> daan Hoogland
>>
>
>
>
> --
>
> Andrija Panić
> --------------------------------------
> http://admintweets.com
> --------------------------------------
--
Daan
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Andrija Panic <an...@gmail.com>.
Hi Daan,
any help needed by me, regarding testing ? Did not catch these automated
emails...
Thanks,
Andrija
On 7 June 2014 10:23, daan Hoogland <da...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated June 7, 2014, 8:23 a.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by
> updating on upgrade
>
> This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
> live testing by Andrija Panic
>
>
> Thanks,
>
> daan Hoogland
>
>
--
Andrija Panić
--------------------------------------
http://admintweets.com
--------------------------------------
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/
-----------------------------------------------------------
(Updated June 7, 2014, 8:23 a.m.)
Review request for cloudstack and Marcus Sorensen.
Repository: cloudstack-git
Description
-------
VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
Diff: https://reviews.apache.org/r/22093/diff/
Testing
-------
live testing by Andrija Panic
Thanks,
daan Hoogland
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/
-----------------------------------------------------------
(Updated June 7, 2014, 8:23 a.m.)
Review request for cloudstack and Marcus Sorensen.
Repository: cloudstack-git
Description
-------
VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
Diff: https://reviews.apache.org/r/22093/diff/
Testing
-------
live testing by Andrija Panic
Thanks,
daan Hoogland
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/
-----------------------------------------------------------
(Updated June 7, 2014, 8:23 a.m.)
Review request for cloudstack and Marcus Sorensen.
Repository: cloudstack-git
Description (updated)
-------
VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
This fix might have to be included in a 4.3.0 to 4.3.1 upgrade as well
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
Diff: https://reviews.apache.org/r/22093/diff/
Testing (updated)
-------
live testing by Andrija Panic
Thanks,
daan Hoogland
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44479
-----------------------------------------------------------
The issue I see with this fix is that it also applies to other hypvervisors and, as far as I know, this is not broken on, at least, XenServer. Thorough testing will be required.
- Joris van Lieshout
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
> On June 2, 2014, 8:52 a.m., Koushik Das wrote:
> > If someone is already on 4.3, is this fix not applicable? Shouldn't this go to 4.3-4.4 upgrade?
yes, will do, I was wondering on this. It is a repeatable conversion so it can go in 4.3.0 to 4.3.1 and in 4.3 to 4.4 as well
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44482
-----------------------------------------------------------
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/#review44482
-----------------------------------------------------------
If someone is already on 4.3, is this fix not applicable? Shouldn't this go to 4.3-4.4 upgrade?
- Koushik Das
On May 30, 2014, 9 p.m., daan Hoogland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22093/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9 p.m.)
>
>
> Review request for cloudstack and Marcus Sorensen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
>
> Diff: https://reviews.apache.org/r/22093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> daan Hoogland
>
>
Re: Review Request 22093: VPC's VR missing public NIC eth1
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22093/
-----------------------------------------------------------
(Updated May 30, 2014, 9 p.m.)
Review request for cloudstack and Marcus Sorensen.
Changes
-------
debug statement
Repository: cloudstack-git
Description
-------
VPC's VR missing public NIC eth1 as reported by Andrija Panic. fix by updating on upgrade
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
Diff: https://reviews.apache.org/r/22093/diff/
Testing
-------
Thanks,
daan Hoogland